[2.6 patch] mark QNX4FS_RW as BROKEN

From: Adrian Bunk (bunk_at_stusta.de)
Date: 10/30/04

  • Next message: update-list: "Get to a higher level fast" 
    Date:	Sat, 30 Oct 2004 23:22:50 +0200
To: Anders Larsen <al@alarsen.net>

    On Sat, Oct 30, 2004 at 07:01:28PM +0000, Anders Larsen wrote:
    > On Sat, Oct 30, 2004 at 08:07:02PM +0200, Adrian Bunk wrote:
    > >The patch below does the following cleanups in the QNX4 fs:
    > >- remove two unused global functions
    >
    > If you remove any code inside the #ifdef CONFIG_QNX4FS_RW we might
    > as well remove the option "config QNX4FS_RW" altogether.
    > It's horribly broken, and I don't intend to fix it; while I was
    > thinking about how to properly implement write-support, somebody else
    > went away and did it. As that alternative seems to work well and is
    > being actively maintained, I won't try to reinvent it.

    OK, I understand why my patch wasn't good.

    What about the following to mark it as BROKEN in the Kconfig file?

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    --- linux-2.6.10-rc1-mm2-full/fs/Kconfig.old 2004-10-30 23:15:17.000000000 +0200
    +++ linux-2.6.10-rc1-mm2-full/fs/Kconfig 2004-10-30 23:15:34.000000000 +0200
    @@ -1353,7 +1353,7 @@
     
     config QNX4FS_RW
             bool "QNX4FS write support (DANGEROUS)"
    - depends on QNX4FS_FS && EXPERIMENTAL
    + depends on QNX4FS_FS && EXPERIMENTAL && BROKEN
             help
               Say Y if you want to test write support for QNX4 file systems.
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: update-list: "Get to a higher level fast"

    Relevant Pages

    • Re: modular IDE in 2.4.23
      ... demand to fix that, and yes I intend to do so if nobody else has - although ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Power Management Update
      ... I encountered this problem by having an IDE CD-ROM, ... He mentioned producing a cleaner patch, but this should at least fix the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] fs/fcntl.c : dont test unsigned value for less than zero
      ... I think the real problem here is that 'arg' ... architecture's ptrace code could easily make use of the latter, ... But be careful not to "fix up" ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Testing RC kernels [KORG]
      ... Can someone with access to the html for kernel.org please fix that? ... We've had several messages now complaining about this. ... Copyright 2005 by Maurice Eugene Heskett, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.4.22-rc2 ext2 filesystem corruption
      ... > # Without this fix it mistakenly assumes that the empty drive slot ... the 64K cylinders problem) I know I saw transfer speeds greater than ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)