Re: [PATCH] Add panic blinking to 2.6
From: Andi Kleen (ak_at_suse.de)
Date: 10/31/04
- Previous message: Jim Nelson: "Re: code bloat [was Re: Semaphore assembly-code bug]"
- In reply to: Chris Wedgwood: "Re: [PATCH] Add panic blinking to 2.6"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Sun, 31 Oct 2004 03:54:18 +0100 To: Chris Wedgwood <cw@f00f.org>
On Sat, Oct 30, 2004 at 07:25:37PM -0700, Chris Wedgwood wrote:
> > +static int blink_frequency = 500;
> > +module_param_named(panicblink, blink_frequency, int, 0600);
>
> does it reall need to be a module?
It isn't a module.
>
> > +/* Returns how long it waited in ms */
> > +long (*panic_blink)(long time) = no_blink;
> > +EXPORT_SYMBOL(panic_blink);
>
> i dont know we can't have this unconditionally with the 500ms period
> (always present and on)
>
> would that really harm anything?
Yes, one broken KVM seems to block switching with it in some cases
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Jim Nelson: "Re: code bloat [was Re: Semaphore assembly-code bug]"
- In reply to: Chris Wedgwood: "Re: [PATCH] Add panic blinking to 2.6"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
