Re: [PATCH 475] HP300 LANCE
From: Andrew Morton (akpm_at_osdl.org)
Date: 10/31/04
- Previous message: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Maybe in reply to: Geert Uytterhoeven: "[PATCH 475] HP300 LANCE"
- Next in thread: Jeff Garzik: "Re: [PATCH 475] HP300 LANCE"
- Reply: Jeff Garzik: "Re: [PATCH 475] HP300 LANCE"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Sun, 31 Oct 2004 02:48:40 -0800 To: Jeff Garzik <jgarzik@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Andrew Morton wrote:
> > Jeff Garzik <jgarzik@pobox.com> wrote:
> >
> >>content looks OK, but patch appears to be whitespace-challenged...
> >>
> >
> >
> > It applies successfully.
>
> I'm talking about the _other_ type of "whitespace challenged", such as,
>
> - volatile struct lance_regs *ll;
> + unsigned long base;
>
> and
>
> - void *va = dio_scodetoviraddr(scode);
> + unsigned long pa = dio_scodetophysaddr(scode);
> + unsigned long va = (pa + DIO_VIRADDRBASE);
>
> Reading through the patch you can see other one-space-off spots.
>
That's because the stoopid driver is using spaces instead of tabs all over
the place. It comes out visually OK once the patch is applied. But it's a
useful reminder of how much dreck we have in the tree.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Maybe in reply to: Geert Uytterhoeven: "[PATCH 475] HP300 LANCE"
- Next in thread: Jeff Garzik: "Re: [PATCH 475] HP300 LANCE"
- Reply: Jeff Garzik: "Re: [PATCH 475] HP300 LANCE"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
