Re: [PATCH 475] HP300 LANCE

From: Andrew Morton (akpm_at_osdl.org)
Date: 10/31/04

  • Next message: Jan Engelhardt: "Re: Kernel 2.6.9 breaks NVidia module, cannot start X." 
    Date:	Sun, 31 Oct 2004 03:09:31 -0800
To: Jeff Garzik <jgarzik@pobox.com>

    Jeff Garzik <jgarzik@pobox.com> wrote:
    >
    > On Sun, Oct 31, 2004 at 02:48:40AM -0800, Andrew Morton wrote:
    > > > - void *va = dio_scodetoviraddr(scode);
    > > > + unsigned long pa = dio_scodetophysaddr(scode);
    > > > + unsigned long va = (pa + DIO_VIRADDRBASE);
    >
    >
    > > That's because the stoopid driver is using spaces instead of tabs all over
    > > the place. It comes out visually OK once the patch is applied. But it's a
    > > useful reminder of how much dreck we have in the tree.
    >
    > Did you see the above quoted patch chunk? The patch is inconsistent
    > with _itself_, adding 'pa' and 'va' with different idents (but when they
    > should be at the same identation level).

    Trust me ;)

    http://www.zip.com.au/~akpm/linux/patches/stuff/x.jpg
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Jan Engelhardt: "Re: Kernel 2.6.9 breaks NVidia module, cannot start X."

    Relevant Pages