Re: [PATCH 475] HP300 LANCE
From: Jeff Garzik (jgarzik_at_pobox.com)
Date: 10/31/04
- Previous message: Jeff Garzik: "Re: [PATCH 475] HP300 LANCE"
- In reply to: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Next in thread: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Reply: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Sun, 31 Oct 2004 05:41:50 -0500 To: Andrew Morton <akpm@osdl.org>
Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>>content looks OK, but patch appears to be whitespace-challenged...
>>
>
>
> It applies successfully.
I'm talking about the _other_ type of "whitespace challenged", such as,
- volatile struct lance_regs *ll;
+ unsigned long base;
and
- void *va = dio_scodetoviraddr(scode);
+ unsigned long pa = dio_scodetophysaddr(scode);
+ unsigned long va = (pa + DIO_VIRADDRBASE);
Reading through the patch you can see other one-space-off spots.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Jeff Garzik: "Re: [PATCH 475] HP300 LANCE"
- In reply to: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Next in thread: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Reply: Andrew Morton: "Re: [PATCH 475] HP300 LANCE"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|