[PATCH] FAT: remove wrong BUG_ON()

From: OGAWA Hirofumi (hirofumi_at_mail.parknet.co.jp)
Date: 10/31/04

  • Next message: OGAWA Hirofumi: "[PATCH] FAT: fix VFAT_IOCTL_READDIR_BOTH ioctl"
    To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
    Date:	Mon, 01 Nov 2004 03:25:44 +0900
    
    

    Hi,

    Please apply

    -- 
    OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    This is valid state if file was accessed by multiple processes at the
    same time.
    Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    ---
     fs/fat/cache.c |    1 -
     1 files changed, 1 deletion(-)
    diff -puN fs/fat/cache.c~fat-cache-bug_on-fix fs/fat/cache.c
    --- linux-2.6.10-rc1/fs/fat/cache.c~fat-cache-bug_on-fix	2004-10-31 08:14:49.000000000 +0900
    +++ linux-2.6.10-rc1-hirofumi/fs/fat/cache.c	2004-10-31 08:14:49.000000000 +0900
    @@ -147,7 +147,6 @@ static void fat_cache_add(struct inode *
     		goto out;	/* this cache was invalidated */
     
     	cache = fat_cache_merge(inode, new);
    -	BUG_ON(new->id == FAT_CACHE_VALID && cache != NULL);
     	if (cache == NULL) {
     		if (MSDOS_I(inode)->nr_caches < fat_max_cache(inode)) {
     			MSDOS_I(inode)->nr_caches++;
    _
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: OGAWA Hirofumi: "[PATCH] FAT: fix VFAT_IOCTL_READDIR_BOTH ioctl"

    Relevant Pages

    • RE: why swap at all?
      ... But this doesn't help in this case as the image-file is up to 4,4GB in ... whole which means that it ALONE can fill up the whole cache. ... Real Programmers consider "what you see is what you get" to be just as ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: statfs() / statvfs() syscall ballsup...
      ... regular writes and read stuff off the disk that was a potential security ... So right now we have extra code and extra complexity (which implies not ... through the page cache to make sure that it's safe. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • fastboot, diskstat
      ... that the total time for prefetching + actual boot was only 10% shorter, ... actually cache the pages I touched, ... Also, regarding the directory entries, are they accessed via the buffer ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.5-rc1-aa1
      ... > spend the 12 bytes for the finegrined tracking, ... are shared between multiple processes, ... be a big disadvantage any more. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: statfs() / statvfs() syscall ballsup...
      ... > touching the page will obviously map in and synchronize the result. ... > populated the cache for a directory structure really quickly using it. ... uptodate, so perhaps calling sys_readaheadon a range always causes ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)