Re: [PATCH] Export ata_scsi_simulate() for use by non-libata drivers

From: Jeff Garzik (jgarzik_at_pobox.com)
Date: 10/14/04

  • Next message: Ben Pfaff: "Re: Spam on the list" 
    Date:	Thu, 14 Oct 2004 13:04:54 -0400
To: Mark Lord <lsml@rtr.ca>

    Mark Lord wrote:
    > +void ata_scsi_simulate(u16 *id,
    > + struct scsi_cmnd *cmd,
    > + void (*done)(struct scsi_cmnd *));

    That you are defining a public function in multiple files should be a
    hint that something is still missing... :) Put a prototype in
    linux/libata.h just like the other public functions, and the patch will
    be OK.

            Jeff

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Ben Pfaff: "Re: Spam on the list"

    Relevant Pages

    • Re: [OT] NULL versus 0 (Re: [PATCH] Use NULL instead of integer 0 in security/selinux/)
      ... > Am I missing some special case? ... have not prototype or function's prototype have ... ... / Kari Hurtta ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: C# COM call with Optional Parameter
      ... variant, then you would pass the value of System.Reflection.Missing.Value to ... to indicate it is truly missing. ... > Public Function GetTasks(Optional ByVal lngUserCode As Long) As> ADODB.Recordset ...
      (microsoft.public.dotnet.languages.csharp)
    • Question about user defined types
      ... I am probably missing something simple here, but I am trying to use a Public function to convert a string to a long and return it to a routine. ... I have tried changing the names in case I had hit a name VB was using but still get the same error. ...
      (microsoft.public.vb.general.discussion)
    • [PATCH] restore skb_copy_datagram, removed from 2.6.11-rc2, breaking VMWare
      ... removes the public function "skb_copy_datagram", breaking VMWare ... (and any other module using that interface *sigh*). ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Set the value of a variable using a variable
      ... Hmm, I don't see how this will "modify" the value of any variable you send to it, am I just missing it? ... "Cor Ligthert" wrote: ... > Public Function calculateAs Integer ...
      (microsoft.public.dotnet.languages.vb)