Re: [PATCH] I2C update for 2.6.9

From: Greg KH (greg_at_kroah.com)
Date: 10/20/04

  • Next message: Giuseppe Bilotta: "Re: Fourth auto-fan control interface proposal" 
    Date:	Tue, 19 Oct 2004 17:18:26 -0700
To: linux-kernel@vger.kernel.org, sensors@stimpy.netroedge.com

    ChangeSet 1.2069, 2004/10/19 15:14:51-07:00, khali@linux-fr.org

    [PATCH] I2C: Spare 1 byte in lm90 driver

    I just noticed the other day that the lm90 driver uses an u16 to store
    the value of the 8-bit alarms register. This is most probably due to the
    fact that I originally copied the lm90 driver from the lm83 driver,
    which actually has two 8-bit registers for alarms, and obviously forgot
    to change the variable type.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>

     drivers/i2c/chips/lm90.c | 2 +-
     1 files changed, 1 insertion(+), 1 deletion(-)

    diff -Nru a/drivers/i2c/chips/lm90.c b/drivers/i2c/chips/lm90.c
    --- a/drivers/i2c/chips/lm90.c 2004-10-19 16:54:14 -07:00
    +++ b/drivers/i2c/chips/lm90.c 2004-10-19 16:54:14 -07:00
    @@ -185,7 +185,7 @@
             s16 temp_input2, temp_low2, temp_high2; /* remote, combined */
             s8 temp_crit1, temp_crit2;
             u8 temp_hyst;
    - u16 alarms; /* bitvector, combined */
    + u8 alarms; /* bitvector */
     };
     
     /*

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Giuseppe Bilotta: "Re: Fourth auto-fan control interface proposal"