Re: [PATCH] pcmcia network drivers cleanup
From: Dominik Brodowski (linux_at_dominikbrodowski.de)
Date: 10/25/04
- Previous message: Rafael J. Wysocki: "Re: 2.6.9-mm1: NForce3 problem (IRQ sharing issue?)"
- Maybe in reply to: Stelian Pop: "[PATCH] pcmcia network drivers cleanup"
- Next in thread: Stelian Pop: "Re: [PATCH] pcmcia network drivers cleanup"
- Reply: Stelian Pop: "Re: [PATCH] pcmcia network drivers cleanup"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 25 Oct 2004 17:36:15 +0200 To: Stelian Pop <stelian@popies.net>, jgarzik@pobox.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
On Mon, Oct 25, 2004 at 05:30:38PM +0200, Stelian Pop wrote:
> > #define INT_MODULE_PARM(n, v) static int n = v; MODULE_PARM(n, "i")
> >
> > static int irq_list[4] = { -1 };
> > MODULE_PARM(irq_list, "1-4i");
> > INT_MODULE_PARM(irq_mask, 0xdeb8);
> >
> > block being replaced with
> >
> >
> > static int irq_list[4] = { -1 };
> > static int irq_mask irq_mask = 0xdeb8;
> >
> > module_parm(irq_mask, int, 0444};
>
> Sure, it is probably saner, but INT_MODULE_PARM is used for quite a
> few other parameters in each driver, and I didn't want to touch
> all of them.
You need to convert all paramters at once, as MODULE_PARM and module_parm()
can't exist in the same module at the same time anyway. Also, as all
INT_MODULE_PARMs were defined to be MODULE_PARM, it should be safe to do so.
Thanks,
Dominik
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Rafael J. Wysocki: "Re: 2.6.9-mm1: NForce3 problem (IRQ sharing issue?)"
- Maybe in reply to: Stelian Pop: "[PATCH] pcmcia network drivers cleanup"
- Next in thread: Stelian Pop: "Re: [PATCH] pcmcia network drivers cleanup"
- Reply: Stelian Pop: "Re: [PATCH] pcmcia network drivers cleanup"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
