Re: Versioning of tree

From: Sam Ravnborg (sam_at_ravnborg.org)
Date: 10/26/04

  • Next message: Bartlomiej Zolnierkiewicz: "Re: 2.6.9-mm1: LVM stopped working"
    Date:	Tue, 26 Oct 2004 21:08:15 +0200
    To: David Vrabel <dvrabel@arcom.com>, Linus Torvalds <torvalds@osdl.org>, Len Brown <len.brown@intel.com>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Linux Kernel list <linux-kernel@vger.kernel.org>
    
    

    On Tue, Oct 26, 2004 at 08:26:33AM -0400, Ryan Anderson wrote:
    > On Tue, Oct 26, 2004 at 12:49:02PM +0100, David Vrabel wrote:
    > > Ryan Anderson wrote:
    > > >
    > > >Well, here's a patch that adds -BKxxxxxxxx to LOCALVERSION when a
    > > >top-level BitKeeper tree is detected.
    > > >[...]
    > > > LOCALVERSION = $(subst $(space),, \
    > > > $(shell cat /dev/null $(localversion-files)) \
    > > >+ $(subst ",,$(localversion-bk)) \
    > >
    > > Surely there's no need for this? Can't the script spit out an
    > > appropriate localversion* file instead?
    >
    > It can, and yes, my first version used that method.
    >
    > Except it never worked. I was able to generate the file before
    > include/linux/version.h was rebuilt, but failed to get it picked up in
    > that. I'm not really sure why.

    The $(wildcard ...) function was executed before you created the file.
    If we shall retreive the version from a SCM then as you already do
    must hide it in a script.
    I want the script only to be executed when we actually ask kbuild to
    build a kernel - so it has to be part of the prepare rule set.
    Furthermore I like to avoid a dependency on perl for a basic kernel.

    Can you retreive the version from bk using a simple shell script?

            Sam
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Bartlomiej Zolnierkiewicz: "Re: 2.6.9-mm1: LVM stopped working"

    Relevant Pages

    • Re: [ANNOUNCE] kpatchup 0.02 kernel patching script
      ... First of all, very nice script. ... it doesn't look like it properly handles empty directories. ... list index out of range ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Versioning of tree
      ... I was unable to find a way to force the script to be run before ... I thought perl was already used somewhere intrinsically during a build. ... and simply use a hash on it, then take a substring of the hash to get a ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: git-pull-script on my linus tree fails..
      ... > but I haven't touched that tree so I shouldn't get merge issues.. ... I guess I can make the "git pull" script do that automatically (some other ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: [Ext-rt-dev] Re: [ANNOUNCE] Linux 2.6 Real Time Kernel
      ... >> If there is the tendency to touch the concurrency controls in general ... > A lot of folks would probably not mind making UI responsiveness ... > but I think in general this type of script would not be a bad addition ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Updated git HOWTO for kernel hackers
      ... changed from this mode/sha1 to that mode/sha1" format). ... exist in the working directory, ... So even if it looks a bit strange, in a script it actually makes perfect ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)