Re: [linux-usb-devel] Re: [2.6 patch] usbnet.c: remove an unused function

From: David Brownell (david-b_at_pacbell.net)
Date: 10/30/04

  • Next message: Benjamin Herrenschmidt: "PCI changes kill USB PM"
    To: linux-usb-devel@lists.sourceforge.net
    Date:	Fri, 29 Oct 2004 17:37:04 -0700
    
    

    On Friday 29 October 2004 16:27, Adrian Bunk wrote:
    > On Fri, Oct 29, 2004 at 04:17:30PM -0700, David Brownell wrote:

    > > p.s. Last I looked, GCC ignored unused inlines; no code
    > > generated, no warnings. Did that change?
    > >...
    >
    > It didn't change.
    >
    > But there are three different possible reactions on my patches:
    > 1. ACK, kill this dead code
    > 2. ups, I really wanted to use this function
    > 3. please keep, code using this function will/might follow in the future
    >
    > Case 1 is the most common case (and this simply removes some dead code).
    >
    > I had until now two times case 2 (which means the code is now better).
    >
    > You are the first person for case 3.

    And presumably there will also be at least a few case 4:

      4. no response, treated as an ACK.

    :)

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Benjamin Herrenschmidt: "PCI changes kill USB PM"

    Relevant Pages

    • Re: [patch 2.6.12] Add -Wno-pointer-sign to HOSTCFLAGS
      ... Although I am a bit nervous about papering over these warnings without ... I still ACK the patch, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] sound/oss/rme96xx.c: fix two check after use
      ... If there are checks, they should be there for a purpose, and any sane ... If they are dead code, ... could provide the correct fix. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Possible BUG in IPv4 TCP window handling, all recent 2.4.x/2.6.x kernels
      ... > It is just a little tcpdump glitch. ... > It is one ACK, ... > with our packet socket. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Firewire
      ... The response packet is getting processed before the status ... response to your request). ... or queue the replies waiting for the ack. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [PATCH] ARCH_HAS_IRQ_PER_CPU avoids dead code in __do_IRQ()
      ... > Then just leave the code as is and let GCC optimize the dead code ... lets readers of __do_IRQimmediately grasp: ... And you'll get compile error's using IRQ_PER_CPU on ie i386, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)