Re: Linux 2.6.9-ac5 - more stupid FAT filesystems

From: Vojtech Pavlik (vojtech_at_suse.cz)
Date: 10/30/04

  • Next message: Ingo Molnar: "Re: [Fwd: Re: [patch] Real-Time Preemption, -RT-2.6.9-mm1-V0.4]" 
    Date:	Sat, 30 Oct 2004 13:04:15 +0200
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>

    On Sat, Oct 30, 2004 at 12:03:08PM +0300, Sami Farin wrote:

    > On Fri, Oct 29, 2004 at 03:40:32PM +0100, Alan Cox wrote:
    > > This update adds some of the more minor fixes as well as a fix
    > > for a nasty __init bug. Nothing terribly pressing for non-S390 users
    > > unless they are hitting one of the bugs described or need the new
    > > driver bits.
    > >
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/alan/linux-2.6/2.6.9/
    > >
    > > 2.6.9-ac5
    > > o Fix oops in and enable IT8212 driver (me)
    > > o Minor delkin driver fix (Mark Lord)
    > > o Fix NFS mount hangs with long FQDN (Jan Kasprzak)
    > > | I've used this version as its clearly correct for 2.6.9
    > > | although it might not be the right future solution
    > > o Fix overstrict FAT checks stopping reading of (Vojtech Pavlik)
    > > some devices like Nokia phones
    >
    > I guess Canon IXUS 400 is overstupid or something.

    No, the patch from me (included in -ac) is completely bogus. The correct
    patch is attached.

    diff -urN linux-2.6.8/fs/fat/inode.c linux-2.6.8-fat/fs/fat/inode.c
    --- linux-2.6.8/fs/fat/inode.c 2004-09-30 15:27:58.343661051 +0200
    +++ linux-2.6.8-fat/fs/fat/inode.c 2004-09-30 15:33:32.820915377 +0200
    @@ -1003,6 +1003,8 @@
                     /* all is as it should be */
             } else if (media == 0xf8 && FAT_FIRST_ENT(sb, 0xfe) == first) {
                     /* bad, reported on pc9800 */
    + } else if (media == 0xf8 && FAT_FIRST_ENT(sb, 0xff) == first) {
    + /* bad, reported on Nokia phone with USB storage */
             } else if (media == 0xf0 && FAT_FIRST_ENT(sb, 0xf8) == first) {
                     /* bad, reported with a MO disk on win95/me */
             } else if (first == 0) { 

    -- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Ingo Molnar: "Re: [Fwd: Re: [patch] Real-Time Preemption, -RT-2.6.9-mm1-V0.4]"

    Relevant Pages

    • Re: Trying to fix radeonfb suspending on IBM Thinkpad T41
      ... under the impression that they require some hacks to work around bugs in ... There is a rather big patch coming, ... since kernel 2.6.10 I have not been able to successfully ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Genes pcHDTV 3000 analog problem
      ... Michael pointed out, 2.6.15 has bugs. ... I do a cold boot to be sure the hardware is fully initialized from a known state. ... I'll try to email you an experimental patch tonight or tomorrow that will remove tda8275a support, just to confirm that this is in fact the problem. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • Re: [PATCH 04/11] hpt366: write the full 4 bytes of ROM address, not just low 1 byte
      ... > didn't Linus find similar bugs in a couple of the other hpt drivers as ... And patch 10/11 does: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] 2.4.22-pre9-bk : bonding bug fixes
      ... >> there are still a few bugs in the current bonding driver. ... and locking fix (third patch) both look good to me. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.6.9-ac5
      ... > This update adds some of the more minor fixes as well as a fix ... > unless they are hitting one of the bugs described or need the new ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)