Re: [2.6 patch] drivers/acpi: remove unused exported functions

From: Adrian Bunk (bunk_at_stusta.de)
Date: 11/06/04

  • Next message: Ricky Beam: "Re: breakage: flex mmap patch for x86-64" 
    Date:	Sat, 6 Nov 2004 22:29:17 +0100
To: Arnaldo Carvalho de Melo <acme@conectiva.com.br>

    On Sat, Nov 06, 2004 at 01:31:06PM -0200, Arnaldo Carvalho de Melo wrote:
    >
    > Suggestion that satisfies both of you, I think:
    >
    > #undef ACPI_FUTURE_USAGE
    > #ifdef ACPI_FUTURE_USAGE
    > tons of unused exported functions
    > #endif /* ACPU_FUTURE_USAGE */
    >
    > This is what is being done in at least one case in the kernel network
    > subsystem, incremental patches adds new functions, to be used by
    > future patches, but sometimes Real Life (tm) gets in the way and the
    > programmer stalls development for some time, no problem, just ifdef it.
    >
    > When, in the future, some functions start being used, hey, very easy
    > to remove the #ifdef.
    >
    > Even for people trying to debug such subsystems eventually to get
    > something working its _nice_ to know at first glance what is really
    > being used, speeding up the process for the benefit or everybody.

    That's a good idea.

    To make it easier, I could send a patc to move all the ACPI
    EXPORT_SYMBOL's away from acpi_ksyms.c or you have to touch two files
    for every function.

    @Len:
    What's your opinion on this proposal?

    > Best Regards,
    >
    > - Arnaldo
    >...

    cu
    Adrian 

    -- 
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Ricky Beam: "Re: breakage: flex mmap patch for x86-64"

    Relevant Pages