Re: RFC: [2.6 patch] saa7146 cleanups

From: Michael Hunold (hunold_at_linuxtv.org)
Date: 11/08/04

  • Next message: Ingo Molnar: "[patch] Real-Time Preemption, -RT-2.6.10-rc1-mm3-V0.7.19"
    Date:	Mon, 08 Nov 2004 08:47:56 +0100
    To: Adrian Bunk <bunk@stusta.de>
    
    

    Hi,

    On 07.11.2004 18:57, Adrian Bunk wrote:
    > The patch below contains the following saa7146 cleanups:
    > - make needlessly global code static
    > - remove unused code

    Thanks!

    > Please comment on this, especially if patches for in-kernel uses of
    > currently unused code are pending.

    saa7146_set_gpio() should really be used by saa7146 based device
    drivers, but isn't at the moment.

    I committed your patches to the LinuxTV.org CVS repository with minor
    changes. Unfortunately, my next patchset is already waiting to be pushed
    to Linus and Andrew, so your patches won't go into mainline immediately.

    CU
    Michael.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Ingo Molnar: "[patch] Real-Time Preemption, -RT-2.6.10-rc1-mm3-V0.7.19"

    Relevant Pages

    • Re: [linux-dvb-maintainer] [2.6 patch] some DVB cleanups
      ... > - make needlessly global code static ... > - remove unused code ... driver co-exist with bttv. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Linux 2.4.30-rc2
      ... I have no problem at all with all these patches not merged, ... to keep unused code because it makes debugging funnier, OK, that's fine. ... Anyway, I'm just proposing, maintainers decide. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] drivers/scsi/FlashPoint.c: cleanups
      ... > - remove other unused code ... > - make needlessly global code static ... And I hope cleaning FlashPoint mess will be splitted. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] some PNP cleanups
      ... > - remove some unused code ... > - make some needlessly global code static ... The patch looks good, but I think I want to keep ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6 patch] mfd/sm501.c: #if 0 unused functions
      ... lines of "it'll be used again soon, so we can reinstate it then". ... we should just remove it outright. ... patches of their own to remove it (for reasons I won't pretend to ... so the unused code just sits there and rots. ...
      (Linux-Kernel)