Re: [patch] Real-Time Preemption, -RT-2.6.10-rc1-mm3-V0.7.18

From: Ingo Molnar (mingo_at_elte.hu)
Date: 11/08/04

  • Next message: Michael Buesch: "Re: [PATCH 2.6] fix address passing of unknown_bootoption"
    Date:	Mon, 8 Nov 2004 10:45:04 +0100
    To: Eran Mann <emann@mrv.com>
    
    

    * Eran Mann <emann@mrv.com> wrote:

    > Ingo Molnar wrote:
    > >i have released the -V0.7.18 Real-Time Preemption patch, which can be
    > >downloaded from:
    > >
    > > http://redhat.com/~mingo/realtime-preempt/
    >
    > I got the attached oops on 2.6.10-rc1-mm3-RT-V0.7.18 (probably during the
    > daily cron job). Later in the morning when I tried to access some
    > filesystems
    > I got the attached deadlock report.

    > Nov 8 04:19:32 eran kernel: BUG at include/linux/spinlock.h:767!
    > Nov 8 04:19:32 eran kernel: ------------[ cut here ]------------
    > Nov 8 04:19:32 eran kernel: kernel BUG at include/linux/spinlock.h:767!

    ok, your bugreport pinpointed the bug: an RT-patch merging mistake when
    i merged -RT to the spinlock-checker changes in recent BK.

    the fix is below, but i've also put it into -V0.7.20 (which i released a
    couple of minutes ago). Does this patch (or -V0.7.20) fix the kjournald
    crash for you?

            Ingo

    --- linux/include/linux/spinlock.h.orig
    +++ linux/include/linux/spinlock.h
    @@ -750,7 +750,7 @@ static inline void bit_spin_lock(int bit
      */
     static inline int bit_spin_trylock(int bitnum, unsigned long *addr)
     {
    -#if defined(CONFIG_SMP) || defined(CONFIG_DEBUG_SPINLOCK)
    +#if defined(CONFIG_SMP) || defined(CONFIG_DEBUG_SPINLOCK) || defined(CONFIG_PREEMPT)
             if (test_and_set_bit(bitnum, addr))
                     return 0;
     #endif
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Michael Buesch: "Re: [PATCH 2.6] fix address passing of unknown_bootoption"

    Relevant Pages

    • Re: Suspend-to-disk woes
      ... > last-mounted dates of filesystems and panic if they changed. ... Then how would you fix it? ... otherwise the kernel will never boot again. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: sysfs: write returns ENOMEM?
      ... all filesystems using the generic page cache routines are able ... I don't think it makes much sense to fix this in individual ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] FAT: Support the large partition (> 128GB) for 2.4
      ... But it was forgetting to fix the mmu_private of ... I suppose all filesystems should be fixed. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH 2.4.23, 2.6.0-test11] fix d_type in readdir in isofs
      ... If there are no objections i'll try to fix some other filesystems too. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Power Management Update
      ... I encountered this problem by having an IDE CD-ROM, ... He mentioned producing a cleaner patch, but this should at least fix the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)