Re: [PATCH] Use MPOL_INTERLEAVE for tmpfs files

From: Hugh Dickins (hugh_at_veritas.com)
Date: 11/09/04

  • Next message: Greg KH: "[PATCH] kobject: fix double kobject_put() in error path of kobject_add()" 
    Date:	Tue, 9 Nov 2004 19:04:25 +0000 (GMT)
To: Brent Casavant <bcasavan@sgi.com>

    On Mon, 8 Nov 2004, Brent Casavant wrote:
    > On Wed, 3 Nov 2004, Martin J. Bligh wrote:
    >
    > > Matt has volunteered to write the mount option for this, so let's hold
    > > off for a couple of days until that's done.
    >
    > I had the time to do this myself. Updated patch attached below.

    Looks pretty good to me.

    Doesn't quite play right with what was my "NULL sbinfo" convention.
    Given this mpol patch of yours, and Adam's devfs patch, it's becoming
    clear that my "NULL sbinfo" was unhelpful, making life harder for both
    of you to add things into the tmpfs superblock - unchanged since 2.4.0,
    as soon as I mess with it, people come up with valid new uses for it.

    Not to say that your patch or Adam's will go further (I've no objection
    to the way Adam is using tmpfs, but no opinion on the future of devfs),
    but they're two hints that I should rework that to get out of people's
    way. I'll do a patch for that, then another something like yours on
    top, for you to go back and check.

    I think the option should be "mpol=interleave" rather than just
    "interleave", who knows what baroque mpols we might want to support
    there in future?

    I'm irritated to realize that we can't change the default for SysV
    shared memory or /dev/zero this way, because that mount is internal.
    But neither you nor Andi were wanting that, so okay, never mind;
    could use his sysctl instead if the need emerges.

    At one time (August) you were worried about MPOL_INTERLEAVE
    overloading node 0 on small files - is that still a worry?
    Perhaps you skirt that issue in recommending this option
    for use with giant files.

    There are quite a lot of mpol patches flying around, aren't there?
    From Ray Bryant and from Steve Longerbeam. Would this tmpfs patch
    make (adaptable) sense if we went either or both of those ways - or
    have they been knocked on the head? I don't mean in the details
    (I think one of them does away with the pseudo-vma stuff - great!),
    but in basic design - would your mount option mesh together well
    with them, or would it be adding a further layer of confusion?

    Hugh

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Greg KH: "[PATCH] kobject: fix double kobject_put() in error path of kobject_add()"