Re: [PATCH] PNP support for i8042 driver

From: matthieu castet (castet.matthieu_at_free.fr)
Date: 11/15/04

  • Next message: James Morris: "[PATCH 3/3] SELinux scalability - AVC statistics and tuning" 
    Date:	Mon, 15 Nov 2004 20:51:20 +0100
To: dtor_core@ameritech.net

    Dmitry Torokhov wrote:
    > On Sun, 14 Nov 2004 13:22:21 +0100, matthieu castet
    > <castet.matthieu@free.fr> wrote:
    >
    >>Dmitry Torokhov wrote:
    >>
    >>
    >>
    >>>On Saturday 13 November 2004 08:23 am, matthieu castet wrote:
    >>>
    >>>
    >>>>Hi,
    >>>>this patch add PNP support for the i8042 driver in 2.6.10-rc1-mm5. Acpi
    >>>>is try before the pnp driver so if you don't disable ACPI or apply
    >>>>others pnpacpi patches, it won't change anything.
    >>>>
    >>>>Please review it and apply if possible
    >>>>
    >>>>thanks,
    >>>>
    >>>>Matthieu CASTET
    >>>>
    >>>>Signed-Off-By: Matthieu Castet <castet.matthieu@free.fr>
    >>>>
    >>>Hi,
    >>>
    >>
    >>Hi,
    >>
    >>>Do we really need to keep those drivers loaded - i8042 will not
    >>>be hotplugged and ports are reserved anyway. We are only interested
    >>>in presence of the keyboard and mouse ports. Can we unregister
    >>>the drivers (both ACPI and PNP) right after registering and mark
    >>>all that stuff as __init/__initdata as in the patch below?
    >>
    >>It is better to keep pnp driver loaded because when it unload, the
    >>resources will be disabled, so for the motherboards that allow it the
    >>irq won't work anymore, and so the keyboard and mouse won't work...
    >
    >
    > Is it possible to leave the device in enabled state or enable device
    > after unloading the driver with PNP?
    Yes you could do a very ugly hack : set pnp_can_disable(dev) to 0 before
      unregister. With that the device won't be disabled (no resource
    desalocation), but the device will be mark as not active in pnp layer.

    > All we need from PNP layer
    > for i8042 is to verify presence of the KBC, we don't need resource
    > management.The ports range is already marked as reserved, IRQ
    > will be requested if needed...
    >
    I don't agree at all :
    - the pci layer allow you to find the device like pnp layer, then you
    register resource with request_region or equivalent. Do we need to do
    the same for all pci driver ?
    - actually the resources are registered in the kernel, but not in the
    bios, why some strange bios can allow to use irq 12 to an other device
    if it isn't used ?
    - Do you save lot's of memory with __init/__initdata ? The pnp code is
    quite small.

    Matthieu
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: James Morris: "[PATCH 3/3] SELinux scalability - AVC statistics and tuning"

    Relevant Pages

    • Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0 sound card
      ... That means the PNP system driver has to be registered after the PCI ... Notice how there is *two* resources there: there's the PCI bus resource ...
      (Linux-Kernel)
    • Re: About using IoCompleteRequest and iostatus blocks Status Field.
      ... You cannot pend most PNP IRP's you need to complete them, ... return STATUS_PENDING or complete the IRP with IoCompleteRequest. ... Your driver doesn't specifiy the resources, ... How can I make sure that, the default resource descriptors, ...
      (microsoft.public.development.device.drivers)
    • Re: [PATCH] smsc-ircc2: Add PnP support.
      ... >>and the pnp probe failed and it disable the resource, ... > even if the serial driver has grabbed the regions. ...
      (Linux-Kernel)
    • Re: [bisected][resend] pnp: Huge number of "io resource overlap" messages
      ... The commit that changed this was: ... PNP: replace pnp_resource_table with dynamically allocated resources ... about "io resource overlaps" for pnp 00:08 in my dmesg, ... Generally, you need it -- if PnP grabs an I/O resource, PCI can no longer do so (making the driver fail) which is the same problem that quirk_system_pci_resourcesupto that point solved for mem resources only. ...
      (Linux-Kernel)
    • Re: Sending child a resource at IRP_MN_START time
      ... If it can be done using varying resource maps, ... either let us do it as well, or fix the PnP setup is my take. ... >>> Is there currently a way for a Physical Device Object to respond to PnP ... >>> Functional Device Object receive its PnP IRP with minor function START ...
      (microsoft.public.development.device.drivers)