[PATCH 2.6] cciss: CCISS_GETLUNINFO fix

mike.miller_at_hp.com
Date: 11/29/04

  • Next message: Remi Colinet: "Re: Real-Time Preemption, -RT-2.6.10-rc2-mm3-V0.7.31-7"
    Date:	Mon, 29 Nov 2004 16:07:25 -0600
    To: akpm@osdl.org, axboe@suse.de
    
    

    This patch addresses a problem with reading the partition table struct.
    The last time this was submitted it was rejected on the grounds that the driver
    has no business reading the partition table. I don't disagree with that, but
    we have legacy apps to consider. Changing the ioctl would break those apps
    already in customers hands.

    Please consider this for inclusion.

    Signed-off-by: Mike Miller <mike.miller@hp.com>
    Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>

     cciss.c | 2 +-
     1 files changed, 1 insertion(+), 1 deletion(-)
    --------------------------------------------------------------------------------
    diff -urNp lx2610-rc1.orig/drivers/block/cciss.c lx2610-rc1-adrianb/drivers/block/cciss.c
    --- lx2610-rc1.orig/drivers/block/cciss.c 2004-11-12 11:17:56.000000000 -0600
    +++ lx2610-rc1-adrianb/drivers/block/cciss.c 2004-11-29 15:54:21.668060552 -0600
    @@ -809,7 +809,7 @@ static int cciss_ioctl(struct inode *ino
                      luninfo.num_opens = drv->usage_count;
                      luninfo.num_parts = 0;
                      /* count partitions 1 to 15 with sizes > 0 */
    - for(i=1; i <MAX_PART; i++) {
    + for(i=0; i < MAX_PART-1; i++) {
                             if (!disk->part[i])
                                     continue;
                             if (disk->part[i]->nr_sects != 0)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Remi Colinet: "Re: Real-Time Preemption, -RT-2.6.10-rc2-mm3-V0.7.31-7"

    Relevant Pages

    • Re: Merging fails reading /dev/uba1
      ... 4KB, while in the second case (partition), all reads are 512 bytes long. ... the key is reading from a partition or not. ... 64 heads, 32 sectors/track, 1000 cylinders ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Trying to find significant factors in experimental results
      ... that anyone else might argue for. ... and thanks for pointing me towards some more reading. ... repeated for every possible partition. ...  My reading of Factorial ANOVA suggests that every population ...
      (sci.stat.edu)
    • Re: How do I transfer speech profiles to other PCs?
      ... > different systems at a mouse-click and I want to use the same speech ... > by using shortcuts to a separate partition. ... >> personal account will be deleted without reading. ...
      (microsoft.public.office.misc)
    • Re: How do I transfer speech profiles to other PCs?
      ... mouse-click and I want to use the same speech profile in each one, ... OS's by using shortcuts to a separate partition. ... > account will be deleted without reading. ... personal account will be deleted without reading. ...
      (microsoft.public.office.misc)
    • Re: 2.4: "access beyond end of device" after ext2 mount
      ... dd: reading `/dev/hdg7': Input/output error ... while the ext3 fs is 9992360 sectors. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)