Re: [PATCH] Cyrix MII cpuid returns stale %ecx

From: H. Peter Anvin (hpa_at_zytor.com)
Date: 12/03/04

  • Next message: Andrea Arcangeli: "Re: [PATCH] oom killer (Core)"
    To: linux-kernel@vger.kernel.org
    Date:	Fri, 3 Dec 2004 22:18:12 +0000 (UTC)
    
    

    Followup to: <20041203090843.GA25528@wotan.suse.de>
    By author: Andi Kleen <ak@suse.de>
    In newsgroup: linux.dev.kernel
    >
    > On Tue, Nov 30, 2004 at 10:07:55PM -0700, Zwane Mwaikambo wrote:
    > > This patch is for the following bug, thanks to Ondrej Zary for
    > > reporting, testing and submitting a patch.
    > >
    > > http://bugzilla.kernel.org/show_bug.cgi?id=3767
    > >
    > > It appears that the Cyrix MII won't touch %ecx at all resulting in stale
    > > data being returned as extended attributes, so clear ecx before issuing
    > > the cpuid. I have also made the capability print code display all the
    > > capability words for easier debugging in future.
    >
    > Can you please change cpuid() on x86-64 too?
    >
    > I think it would be also better to not printk the capabilities
    > at all or only with a special kernel option. Normally they are
    > not needed, but they clutter up the boot log.
    >

    Since this is a bug fix for Cyrix MII, which isn't x86-64, it seems
    pointless to do it for x86-64.

            -hpa
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Andrea Arcangeli: "Re: [PATCH] oom killer (Core)"

    Relevant Pages

    • Re: SUCCESS Re: 2.6.0-test11-mm1
      ... >> patch that's responsible, but it'd take a month to find out anything ... :-/ At least part of the bug (galeon misplaces text) still ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: invalid SMP mptable on Toshiba Satellite 2430-301
      ... Can you send the patch over? ... > SMP mptable is a BIOS bug on my machine. ... I think it's a Linux bug too, although I'll agree that it was triggered by ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] oom killer (Core)
      ... > that change sure it's not a bug in my patch, ... > lowlatency patch would expose the same bug too since they're aliasing ... patching file mm/page_alloc.c ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [patch] improve SMP reschedule and idle routines
      ... >>I'll test this once you work out that obvious bug. ... No difference in the tbench ... > will put the patch in -mm for a while. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] Cyrix MII cpuid returns stale %ecx
      ... testing and submitting a patch. ... I have also made the capability print code display all the ... Can you please change cpuid() on x86-64 too? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)