Re: realtek r8169 + kernel 2.4.24 (openmosix)

From: Francois Romieu (romieu_at_fr.zoreil.com)
Date: 12/04/04

  • Next message: Håvard Kvålen: "Re: kernel CVS is malfunctioning" 
    Date:	Sat, 4 Dec 2004 18:33:27 +0100
To: Nicholas Papadakos <panic@quake.gr>

    Nicholas Papadakos <panic@quake.gr> :
    [...]
    > I copied the latest r8169.c file from kernel 2.4.28 but it didn't compile at
    > all giving an error message:
    >
    > r8169.c: In function `rtl8169_init_board':
    > r8169.c:683: warning: implicit declaration of function `SET_NETDEV_DEV'

    Don't bother: comment out this line.

    > r8169.c:683: error: structure has no member named `dev'
    > r8169.c: In function `rtl8169_make_unusable_by_asic':
    > r8169.c:1164: warning: integer constant is too large for "long" type
    > make[2]: *** [r8169.o] Error 1

    Please apply:

    --- drivers/net/r8169.c 2004-12-04 18:22:18.000000000 +0100
    +++ drivers/net/r8169.c 2004-12-04 18:22:37.000000000 +0100
    @@ -1161,7 +1161,7 @@ rtl8169_hw_start(struct net_device *dev)
     
     static inline void rtl8169_make_unusable_by_asic(struct RxDesc *desc)
     {
    - desc->addr = 0x0badbadbadbadbad;
    + desc->addr = 0x0badbadbadbadbadull;
             desc->status &= ~cpu_to_le32(OWNbit | RsvdMask);
     }
     
    [...]
    > The patch I previously applied was a patch made by you in personal and it
    > was posted in this mailing list.
    > The patch name was : r8169-debug.patch and it contained the following.
    >
    > --- r8169.c-realtek 2004-01-17 14:14:50.000000000 +0100
    > +++ r8169.c-debug 2004-01-17 14:17:25.000000000 +0100
    > @@ -1290,6 +1290,11 @@ static void rtl8169_tx_interrupt (struct
    > dirty_tx = priv->dirty_tx;
    > tx_left = priv->cur_tx - dirty_tx;
    >
    > + if (entry + tx_left > NUM_TX_DESC) {
    > + printk(KERN_ERR, "r8169 bug. Please mail
    > netdev@oss.sgi.com\n");
    > + return;
    > + }
    > +
    > while (tx_left > 0) {
    > if( (priv->TxDescArray[entry].status & OWNbit) == 0 ){
    > dev_kfree_skb_irq( priv->Tx_skbuff[dirty_tx %
    > NUM_TX_DESC] );

    It was just a debug patch, not a fix.

    [info removed]

    Thanks.

    Would your application benefit from larger (> 1500 bytes) frames ?

    (no need to include a complete copy of the original message) 

    --
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Håvard Kvålen: "Re: kernel CVS is malfunctioning"

    Relevant Pages

    • [PATCH] make O=foo does not fail if foo does not exist
      ... build continued in the source directory anyway. ... This patch causes the ... although with a non-obvious error message. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • IDE bug - was: Re: uncorrectable ext2 errors
      ... > behind the 137 GB limit without an error message, ... In my above post I gave a patch for 2.6.0-test3. ... But the IDE code for 2.4 and 2.6 is very similar, so the patch, once applied ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: keyboard - was: Re: Linux 2.6.0-test4
      ... >> I was able to get the key unstuck by switching back and forth between ... I rebuild my kernel including your patch; ... I'll get back to you once I verify that the problem doesn't occur ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables
      ... > For VISWS I think you actually need to turn paging off explicitly. ... The patch will need a few tweaks but it should be fairly straight forward. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)