Re: [BK PATCH] SCSI -rc fixes for 2.6.10-rc3

From: Jens Axboe (axboe_at_suse.de)
Date: 12/10/04

  • Next message: Lee Revell: "Re: [WISHLIST] IBM HD Shock detection in Linux" 
    Date:	Fri, 10 Dec 2004 21:11:16 +0100
To: James Bottomley <James.Bottomley@SteelEye.com>

    On Thu, Dec 09 2004, James Bottomley wrote:
    > This one is another set of small driver fixes
    >
    > It is available from:

    Here is one more. Currently imm uses page_address() which can crash on
    highmem. It's not directly doable to map the pages properly, at least
    not without changing some code. In lack of a ->bounce_highio member in
    the scsi host template, just set ->unchecked_isa_dma which will just
    bounce everything for us. imm isn't performance critical by any stretch
    of the imagination, so...

    Usually I'd not encourage such a silly hack, but in lack of hardware for
    testing (who has it??), this should suffice as it is obviously correct.

    Signed-off-by: Jens Axboe <axboe@suse.de>

    ===== drivers/scsi/imm.c 1.39 vs edited =====
    --- 1.39/drivers/scsi/imm.c 2004-08-25 01:09:03 +02:00
    +++ edited/drivers/scsi/imm.c 2004-12-10 21:07:29 +01:00
    @@ -1140,6 +1140,10 @@
             .use_clustering = ENABLE_CLUSTERING,
             .can_queue = 1,
             .slave_alloc = imm_adjust_queue,
    + .unchecked_isa_dma = 1, /* imm cannot deal with highmem, so
    + * this is an easy trick to ensure
    + * all io pages for this host reside
    + * in low memory */
     };
     
     /*************************************************************************** 

    -- 
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Lee Revell: "Re: [WISHLIST] IBM HD Shock detection in Linux"

    Relevant Pages