Re: kernel BUG at mm/rmap.c:480 in 2.6.10-rc3-bk7

From: Hugh Dickins (hugh_at_veritas.com)
Date: 12/16/04

  • Next message: Willy Tarreau: "Re: bind() udp behavior 2.6.8.1" 
    Date:	Thu, 16 Dec 2004 05:18:59 +0000 (GMT)
To: Greg KH <greg@kroah.com>

    On Wed, 15 Dec 2004, Greg KH wrote:
    > On Wed, Dec 15, 2004 at 11:48:26PM +0100, Andrea Arcangeli wrote:
    > > On Wed, Dec 15, 2004 at 08:03:43PM +0100, Andrea Arcangeli wrote:
    > > > + if (page->mapping)
    > > > + page_remove_rmap(page);
    > >
    > > This had to be page_mapping, since I believe the page->mapping can go
    > > away with the truncate while the page is still being mapped.

    Actually, the patch tests page_mapped(page) not page_mapping(page).

    And is correct (though weak) to do so, in the context of Andrea's
    other changes (which I intentionally omitted when merging anon_vma,
    yes - but let's concentrate on Greg's crash for now, and leave the
    flames about that merge until dessert).

    I'm afraid it is trivial that that hunk alone will avoid the problem,
    just as simply removing the page_remove_rmap's BUG_ON would. But
    neither sheds any light on what is going on here.

    Something is happening that we don't expect. I say "we" - or do you
    understand it, Andrea? We need to understand it before deciding how
    to handle it, perhaps at the mm end or perhaps at the DRM end.

    > No oops with this patch or odd messages in the syslog! It works fine
    > for me, thanks a lot.
    >
    > I'll let the mm developers battle it out to determine if this is a good
    > fix or not :)

    Bug avoidance rather than fix, I'm afraid. Once we understand what's
    going on, such avoidance may be the right course of action; but not yet.

    Hugh

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Willy Tarreau: "Re: bind() udp behavior 2.6.8.1"

    Relevant Pages

    • Re: Power Management Update
      ... I encountered this problem by having an IDE CD-ROM, ... He mentioned producing a cleaner patch, but this should at least fix the ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] fs/fcntl.c : dont test unsigned value for less than zero
      ... I think the real problem here is that 'arg' ... architecture's ptrace code could easily make use of the latter, ... But be careful not to "fix up" ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Testing RC kernels [KORG]
      ... Can someone with access to the html for kernel.org please fix that? ... We've had several messages now complaining about this. ... Copyright 2005 by Maurice Eugene Heskett, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.4.22-rc2 ext2 filesystem corruption
      ... > # Without this fix it mistakenly assumes that the empty drive slot ... the 64K cylinders problem) I know I saw transfer speeds greater than ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.4.23aa2 (bugfixes and important VM improvements for the high end)
      ... That may well fix all problems 2.6 would have otherwise had ... > from the tail of the LRU which were moved there at interrupt time. ... Forget about me proposing the OVM stuff;) ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)