Re: [patch] [RFC] move 'struct page' into its own header
From: Christoph Hellwig (hch_at_infradead.org)
Date: 12/16/04
- Previous message: Adrian Bunk: "[7/11] bttv-driver.c: make some variables static (fwd)"
- In reply to: Dave Hansen: "[patch] [RFC] move 'struct page' into its own header"
- Next in thread: Dave Hansen: "Re: [patch] [RFC] move 'struct page' into its own header"
- Reply: Dave Hansen: "Re: [patch] [RFC] move 'struct page' into its own header"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 16 Dec 2004 22:25:13 +0000 To: Dave Hansen <haveblue@us.ibm.com>
On Thu, Dec 16, 2004 at 02:04:15PM -0800, Dave Hansen wrote:
>
> There are currently 24 places in the tree where struct page is
> predeclared. However, a good number of these places also have to
> do some kind of arithmetic on it, and end up using macros because
> static inlines wouldn't have the type fully definied at
> compile-time.
>
> But, in reality, struct page has very few dependencies on outside
> macros or functions, and doesn't really need to be a part of the
> header include mess which surrounds many of the VM headers.
>
> So, put 'struct page' into structpage.h, along with a nasty comment
> telling everyone to keep their grubby mitts out of the file.
>
> Now, we can use static inlines for almost any 'struct page'
> operations with no problems, and get rid of many of the
> predeclarations.
What about calling it page.h? structfoo.h sounds like a really strange
name. And while you're at it page-flags.h should probably be merged into
it.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Adrian Bunk: "[7/11] bttv-driver.c: make some variables static (fwd)"
- In reply to: Dave Hansen: "[patch] [RFC] move 'struct page' into its own header"
- Next in thread: Dave Hansen: "Re: [patch] [RFC] move 'struct page' into its own header"
- Reply: Dave Hansen: "Re: [patch] [RFC] move 'struct page' into its own header"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
