[2.6 patch] SCSI NCR53C9x.c: some cleanups (fwd)

From: Adrian Bunk (bunk_at_stusta.de)
Date: 12/21/04

  • Next message: Adrian Bunk: "[2.6 patch] SCSI ips.c: make some code static (fwd)"
    Date:	Tue, 21 Dec 2004 01:41:53 +0100
    To: Andrew Morton <akpm@osdl.org>
    
    

    The patch forwarded below still applies and compiles against
    2.6.10-rc3-mm1.

    Please apply.

    ----- Forwarded message from Adrian Bunk <bunk@stusta.de> -----

    Date: Mon, 15 Nov 2004 03:18:26 +0100
    From: Adrian Bunk <bunk@stusta.de>
    To: James.Bottomley@SteelEye.com
    Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
    Subject: [2.6 patch] SCSI NCR53C9x.c: some cleanups

    The patch below contains some cleanups.

    Please review the fact that the function esp_command currently has zero
    users.

    diffstat output:
     drivers/scsi/NCR53C9x.c | 15 ++-------------
     drivers/scsi/NCR53C9x.h | 1 -
     2 files changed, 2 insertions(+), 14 deletions(-)

    Signed-off-by: Adrian Bunk <bunk@stusta.de>

    --- linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.h.old 2004-11-13 16:27:49.000000000 +0100
    +++ linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.h 2004-11-13 16:27:41.000000000 +0100
    @@ -660,7 +660,6 @@
     extern irqreturn_t esp_intr(int, void *, struct pt_regs *);
     extern const char *esp_info(struct Scsi_Host *);
     extern int esp_queue(Scsi_Cmnd *, void (*done)(Scsi_Cmnd *));
    -extern int esp_command(Scsi_Cmnd *);
     extern int esp_abort(Scsi_Cmnd *);
     extern int esp_reset(Scsi_Cmnd *);
     extern int esp_proc_info(struct Scsi_Host *shost, char *buffer, char **start, off_t offset, int length,
    --- linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.c.old 2004-11-13 16:24:51.000000000 +0100
    +++ linux-2.6.10-rc1-mm5-full/drivers/scsi/NCR53C9x.c 2004-11-13 16:28:23.000000000 +0100
    @@ -100,7 +100,7 @@
     irqreturn_t esp_intr(int irq, void *dev_id, struct pt_regs *pregs);
     
     /* Debugging routines */
    -struct esp_cmdstrings {
    +static struct esp_cmdstrings {
             unchar cmdchar;
             char *text;
     } esp_cmd_strings[] = {
    @@ -505,7 +505,7 @@
     }
     
     /* This places the ESP into a known state at boot time. */
    -void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
    +static void esp_bootup_reset(struct NCR_ESP *esp, struct ESP_regs *eregs)
     {
             volatile unchar trash;
     
    @@ -1271,17 +1271,6 @@
             return 0;
     }
     
    -/* Only queuing supported in this ESP driver. */
    -int esp_command(Scsi_Cmnd *SCpnt)
    -{
    -#ifdef DEBUG_ESP
    - struct NCR_ESP *esp = (struct NCR_ESP *) SCpnt->device->host->hostdata;
    -#endif
    -
    - ESPLOG(("esp%d: esp_command() called...\n", esp->esp_id));
    - return -1;
    -}
    -
     /* Dump driver state. */
     static void esp_dump_cmd(Scsi_Cmnd *SCptr)
     {

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    ----- End forwarded message -----

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Adrian Bunk: "[2.6 patch] SCSI ips.c: make some code static (fwd)"

    Relevant Pages

    • [PATCH][2.4 Backport] x445 usb legacy fix
      ... The solution is to disable the BIOS's USB Legacy support early in boot ... Unlike the 2.6 version of the patch, this one also includes a ported ... extern int cyclone_setup; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] cifs: whitespace cleanups for fcntl.c
      ... Here's a patch with cleanups for fs/cifs/fcntl.c ... This time the file is so small and the cleanups so trivial that I chose to ... +int cifs_dir_notify ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] net/seeq8005.c: small cleanups (fwd)
      ... The trivial patch forwarded below still applies and compiles against ... The patch below does the following small cleanups in seeq8005.c: ... send the line "unsubscribe linux-kernel" in ... Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)
    • [2.6 patch] small MCA cleanups (fwd)
      ... The patch forwarded below still applies and compiles against ... The patch below does the following cleanups in the MCA code: ... extern int mca_find_unused_adapter; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] drivers/ide/: possible cleanups
      ... This patch contains the following possible cleanups: ... make a needlessly global function static ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)