Re: [oops] # rmmod snd_nm256
From: Takashi Iwai (tiwai_at_suse.de)
Date: 12/30/04
- Previous message: Bill Davidsen: "Re: disabling IRQs cause nobody cares (incl. oops)"
- In reply to: Paweł Sikora: "[oops] # rmmod snd_nm256"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 30 Dec 2004 17:12:24 +0100 To: Paweł Sikora <pluto@pld-linux.org>
At Thu, 30 Dec 2004 00:59:42 +0100,
Paweł Sikora wrote:
>
> # rmmod snd_nm256
> Oops: 0000 [#1]
Does the patch below fix the problem?
Takashi
--- linux/sound/pci/nm256/nm256.c 27 Dec 2004 13:32:57 -0000 1.61
+++ linux/sound/pci/nm256/nm256.c 30 Dec 2004 16:10:00 -0000
@@ -1486,12 +1486,6 @@
snd_nm256_init_chip(chip);
- if ((err = snd_nm256_pcm(chip, 0)) < 0)
- goto __error;
-
- if ((err = snd_nm256_mixer(chip)) < 0)
- goto __error;
-
// pci_set_master(pci); /* needed? */
snd_card_set_pm_callback(card, nm256_suspend, nm256_resume, chip);
@@ -1612,6 +1606,12 @@
chip->reset_workaround = 1;
}
+ if ((err = snd_nm256_pcm(chip, 0)) < 0 ||
+ (err = snd_nm256_mixer(chip)) < 0) {
+ snd_card_free(card);
+ return err;
+ }
+
sprintf(card->shortname, "NeoMagic %s", card->driver);
sprintf(card->longname, "%s at 0x%lx & 0x%lx, irq %d",
card->shortname,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Bill Davidsen: "Re: disabling IRQs cause nobody cares (incl. oops)"
- In reply to: Paweł Sikora: "[oops] # rmmod snd_nm256"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
