Re: [RFC 2.6.10 1/22] xfrm: Add direction information to xfrm_state

From: Dave Dillow (dave_at_thedillows.org)
Date: 12/30/04

  • Next message: Oleg Nesterov: "Re: [PATCH] rcu: speed up quiescent state detection" 
    To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Date:	Thu, 30 Dec 2004 11:16:49 -0500

    On Thu, 2004-12-30 at 04:48, Jan-Benedict Glaw wrote:
    > On Thu, 2004-12-30 03:48:34 -0500, David Dillow <dave@thedillows.org>
    > wrote in message <20041230035000.10@ori.thedillows.org>:
    > > diff -Nru a/include/net/xfrm.h b/include/net/xfrm.h
    > > --- a/include/net/xfrm.h 2004-12-30 01:12:08 -05:00
    > > +++ b/include/net/xfrm.h 2004-12-30 01:12:08 -05:00
    > > @@ -146,6 +146,9 @@
    > > /* Private data of this transformer, format is opaque,
    > > * interpreted by xfrm_type methods. */
    > > void *data;
    > > +
    > > + /* Intended direction of this state, used for offloading */
    > > + int dir;
    > > };
    > >
    > > enum {
    > > @@ -157,6 +160,12 @@
    > > XFRM_STATE_DEAD
    > > };
    > >
    > > +enum {
    > > + XFRM_STATE_DIR_UNKNOWN,
    > > + XFRM_STATE_DIR_IN,
    > > + XFRM_STATE_DIR_OUT,
    > > +};
    >
    > Any specific reason to first define such a nice enum and then using int
    > in the struct?

    Just following the current style in net/xfrm.h, see xfrm_state.km.state
    and XFRM_STATE_*.

    Though, I probably should have used a u8; easily changed if it is an
    issue. 

    -- 
Dave Dillow <dave@thedillows.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Oleg Nesterov: "Re: [PATCH] rcu: speed up quiescent state detection"

    Relevant Pages