Re: PATCH: kmalloc packet slab
From: Andi Kleen (ak_at_muc.de)
Date: 12/30/04
- Previous message: Davide Libenzi: "Re: ptrace single-stepping change breaks Wine"
- In reply to: Alan Cox: "PATCH: kmalloc packet slab"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: Alan Cox <alan@lxorguk.ukuu.org.uk> Date: Thu, 30 Dec 2004 19:00:25 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> The networking world runs in 1514 byte packets pretty much all the time.
> This adds a 1620 byte slab for such objects and is one of the internally
> generated Red Hat patches we use on things like Fedora Core 3. Original:
> Arjan van de Ven.
Doesnt this clash a bit with yours and Arjans no-prisoners-taken
quest to get rid of order>0 allocations? (4K stacks).
I implemented this long ago (in 2.1 - bonus points if you still find
the leftover hook), but then gave up on it. I realized that to
use it you would need order>0 allocations. In a single 4K page only 2
1.5K slabs fit, but 2 2K slabs fit as well. And there is already a handy
2K slab that works perfect well.
IMHO it is useless except for architectures with PAGE_SIZE>4K or if
you fix the VM to handle order>0 allocations really well. If you want
to add it for sparc64/ia64/alpha etc. I would do it with an ifdef
at least.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Davide Libenzi: "Re: ptrace single-stepping change breaks Wine"
- In reply to: Alan Cox: "PATCH: kmalloc packet slab"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|