Re: bug: cd-rom autoclose no longer works (fix attempt)
From: Stas Sergeev (stsp_at_aknet.ru)
Date: 12/30/04
- Previous message: Daniel Roesen: "[PATCH] trivial comment wording/typo fix regarding taint flags"
- In reply to: Alexander Kern: "Re: bug: cd-rom autoclose no longer works (fix attempt)"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Thu, 30 Dec 2004 23:35:03 +0300 To: Alexander Kern <alex.kern@gmx.de>
Hello.
Alexander Kern wrote:
> Can agree with you, but a modern cdrom should be able to konwn, is it open or
> not. This patch change basic behaviour for all cdroms.
But I think those modern cdroms will
return 1 or 2 but not 0, in which case
my patch should not affect them. This
is of course something I can't say for
sure, just assuming.
> Old behaviour has another problems, and revert to 2.4.20 code base is a bad
> solution.
Very probably. My patch was only "what
I did to get it to work again" kind of
thing.
> The patch must be minimal...
> if (sense.sense_key == NOT_READY) {
OK, but the cdrom.c change is still needed
either. So attached is the new one. Does it
get us any closer to having this fixed?
> P.S. S Novym Godom!
OK, thanks, and to you too:)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- text/x-patch attachment: cd_clo1.diff
- Previous message: Daniel Roesen: "[PATCH] trivial comment wording/typo fix regarding taint flags"
- In reply to: Alexander Kern: "Re: bug: cd-rom autoclose no longer works (fix attempt)"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
