Re: Current saa7134 driver breaks KNC One Tv-Station DVR (card=24)

From: Johannes Stezenbach (js_at_linuxtv.org)
Date: 12/31/04

  • Next message: Coywolf Qi Hunt: "Re: [PATCH] /proc/sys/kernel/bootloader_type"
    Date:	Fri, 31 Dec 2004 15:16:48 +0100
    To: Rusty Russell <rusty@rustcorp.com.au>
    
    

    On Fri, Dec 31, 2004 at 07:29:47PM +1100, Rusty Russell wrote:
    > On Fri, 2004-12-31 at 03:08 +0100, Johannes Stezenbach wrote:
    > > I've reported this before:
    > > http://lkml.org/lkml/2004/11/17/275
    > >
    > > The patch that Rusty posted doesn't seem to have it made into
    > > module-init-tools-3.1. Bummer :-(
    >
    > Because it was a dumb idea, as your reply showed. You can't load any
    > dependent modules because this module is not initialized yet (what if
    > you loaded a module that depended on you, then failed your
    > initialization?). Gerd has the real fix, IIRC.

    Yeah, but IMHO it would be better if modprobe would bail out
    with an error instead of just hanging. For me hotplug
    loads the drivers at boot time and it's a bad good thing if
    the whole boot process hangs.

    Johannes
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Coywolf Qi Hunt: "Re: [PATCH] /proc/sys/kernel/bootloader_type"

    Relevant Pages

    • Re: Current saa7134 driver breaks KNC One Tv-Station DVR (card=24)
      ... > The patch that Rusty posted doesn't seem to have it made into ... dependent modules because this module is not initialized yet (what if ... initialization?). ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [was: Linux v2.6.14-rc4] fix textsearch build warning
      ... lib/ts_fsm.c:318: warning: initialization from incompatible pointer type ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH/RFT 4/5] CLOCK-Pro page replacement
      ... such as IPVS, some S390 drivers, and some other platform specific ... I do note two important spots where the initialization is not ... the loopback driver statistics and the scsi_done_q. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Kernel 2.6.9 2nd SCSI Driver Compiliation Error w/GCC-3.4.2
      ... drivers/scsi/pci2000.c:825: warning: initialization from incompatible ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: p = kmalloc(sizeof(*p), )
      ... Initialization of *p should be nearby, finding it by type name is useful ... For uniformity's sake I'd prefer "sizeof(struct foo)" ... initial coding convenience everyday. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)