[PATCH] remove outdated/misleading CPU scheduler comments

From: Josh Aas (josha_at_sgi.com)
Date: 12/31/04

  • Next message: pmarques_at_grupopie.com: "Re: sh: inconsistent kallsyms data" 
    Date:	Fri, 31 Dec 2004 12:59:09 -0600
To: linux-kernel@vger.kernel.org

    This patch removes two outdated/misleading comments from the CPU scheduler.

    1) The first comment removed is simply incorrect. The function it
    comments on is not used for what the comments says it is anymore.
    2) The second comment is a leftover from when the "if" block it comments
    on contained a goto. It does not any more, and the comment doesn't make
    sense.

    There isn't really a reason to add different comments, though someone
    might feel differently in the case of the second one. I'll leave adding
    a comment to anybody who wants to - more important to just get rid of
    them now.

    Signed-off-by: Josh Aas <josha@sgi.com> 

    -- 
Josh Aas
Linux System Software
Silicon Graphics, Inc. (SGI)

    --- a/kernel/sched.c Fri Dec 24 15:35:24 2004
    +++ b/kernel/sched.c Fri Dec 31 12:28:09 2004
    @@ -580,11 +580,6 @@ static void enqueue_task(struct task_str
             p->array = array;
     }
     
    -/*
    - * Used by the migration code - we pull tasks from the head of the
    - * remote queue so we want these tasks to show up at the head of the
    - * local queue:
    - */
     static inline void enqueue_task_head(struct task_struct *p, prio_array_t *array)
     {
             list_add(&p->run_list, array->queue + p->prio);
    @@ -2585,10 +2580,7 @@ need_resched_nonpreemptible:
     
             if (unlikely(current->flags & PF_DEAD))
                     current->state = EXIT_DEAD;
    - /*
    - * if entering off of a kernel preemption go straight
    - * to picking the next task.
    - */
    +
             switch_count = &prev->nivcsw;
             if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
                     switch_count = &prev->nvcsw;

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: pmarques_at_grupopie.com: "Re: sh: inconsistent kallsyms data"

    Relevant Pages