Re: 256 apic id for amd64

From: Andi Kleen (ak_at_muc.de)
Date: 01/07/05

  • Next message: Andi Kleen: "Re: [discuss] Re: [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat" 
    Date:	7 Jan 2005 13:24:34 +0100
Date:	Fri, 7 Jan 2005 13:24:34 +0100
To: YhLu <YhLu@tyan.com>

    On Thu, Jan 06, 2005 at 06:53:11PM -0800, YhLu wrote:
    > static unsigned int phys_pkg_id(int index_msb)
    > {
    > return hard_smp_processor_id() >> index_msb;
    > }
    >
    > In arch/x86_64/kernel/genapic_cluster.c
    >
    > Should be changed to
    >
    > static unsigned int phys_pkg_id(int index_msb)
    > {
    > /* physical apicid, so we need to substract offset */
    > return (hard_smp_processor_id() - boot_cpu_id) >> index_msb;
    > }

    Why?

    If you want a patch merged you need to supply some more explanation
    please.

    Also cc Suresh & James for comment.

    -Andi

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Andi Kleen: "Re: [discuss] Re: [PATCH] macros to detect existance of unlocked_ioctl and ioctl_compat"

    Relevant Pages

    • Re: DMA problem
      ... SuSE, Debian, Mandrake, RedHat? ... > If I insert a cdrom in the drive the led doesn't go out, ... > Could someone give me an explanation of what is happening and a way to ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: whats next for the linux kernel?
      ... You come onto the Linux kernel mailing list, ... insulting the populace by claiming they would not understand ... real insight or explanation of the issues, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: How to add/drop SCSI drives from within the driver?
      ... access fails. ... >> James, I've been thinking about this a little more, and you ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)
    • Re: [PATCH 01/04] Adding cipher mode context information to crypto_tfm
      ... > but in fact this C99 extension just sucks. ... > scatterwalker, so please Andrew, merge after a successful test of James. ... Ditto. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Some thoughts about stable kernel development
      ... > This does highlight a real issue - I am concerned by the number of ... On the other hand, Linux is about freedom, even if it's the freedom ... I think that James Bourne's -uv patch series ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)