Re: Screwy clock after apm suspend

From: Pavel Machek (pavel_at_suse.cz)
Date: 01/10/05

  • Next message: Ingo Molnar: "Re: [PATCH 2.6.10-mm2] Use the new preemption code [2/3] Resend" 
    Date:	Mon, 10 Jan 2005 11:57:59 +0100
To: bernard@blackham.com.au

    Hi!

    > > > Probably code to compensate clock after ACPI suspend breaks apm case
    > > >
    > > > arch/i386/kernel/time.c, can you comment out
    > > > jiffies += sleep_length * HZ;
    > > >
    > > > in timer_resume to see if it goes away?
    > >
    > > Worked like a charm. I'm not seeing any time drift after your suggested
    > > change.
    >
    > AIUI, this also means that a machine's uptime does not include time
    > whilst suspended. This was the behaviour prior to 2.6.10 and seems to be
    > more desirable as it counts the time the machine is actually running,
    > not just time since boot. Is there a good reason why we can't go back to
    > this?

    I think it means very wrong system clock in ACPI state. Plus think
    something wanting timeout of five minutes, then suspend one minute
    after, machine sleeps for a hour.

    With this approach, timeout should happen just after resume, with your
    approach, it would wait 4 more minutes.

    [Perhaps it needs to call lost_ticks or something like that.]

                                                                            Pavel 

    -- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Ingo Molnar: "Re: [PATCH 2.6.10-mm2] Use the new preemption code [2/3] Resend"

    Relevant Pages

    • Re: Suspend 2 merge
      ... since swsusp1 cheats and discards caches. ... before suspend attempt 800MB were in use. ... half-of-memory limit does not bite too badly). ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rc2-mm1 swsusp bug report.
      ... > It is easy to lose sight of the user perspective on these things if all ... > sprinkling the code with panics, ... never fails to suspend and is in Linus' tree. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: swsusp disk fails in bk-current - intel_agp at fault?
      ... You are right, for resume-during-suspend, we may as well risk it. ... > suspend and Nigel's partial device trees) would be so much ... :-) I think we can simply make device freeze/unfreeze fast enough. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [lhcs-devel] Re: [PATCH][2.6-mm] i386 Hotplug CPU
      ... we steer the APs straight into the offline cpu ... I do not understand what AP and BSP means in this context. ... we can just shut those cpus down on suspend and completely boot ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    Loading