Re: [PATCH] /driver/net/wan/sbs520

From: Francois Romieu (romieu_at_fr.zoreil.com)
Date: 01/10/05

  • Next message: YhLu: "RE: 256 apic id for amd64" 
    Date:	Mon, 10 Jan 2005 21:29:47 +0100
To: Adam Anthony <AAnthony@sbs.com>

    Adam Anthony <AAnthony@sbs.com> :
    > Thank you for the heads up A&M. I have destroyed the evil [^M]'s, and
    > updated the package.
    > http://prdownloads.sourceforge.net/sbs520lnxdrv/sbs520patch.bz2?download

    o OsMapPhysToVirt
      -> should be ioremap/pci_iomap()

    o OsUnMapVirt
      -> iounmap, etc.

    o OsAllocateNonPagedMemory/OsMemcpy/OsStall/OsSleep/OsZeroMem
      -> useless wrappers.

    o OsAllocateDeviceMemory
      Yuck, virt_to_bus !
      Please read:
      - linux-2.6.x/Documentation/DMA-mapping.txt
      - linux-2.6.x/Documentation/DMA-API.txt
      drivers/net/*.c provides a lot of good examples for recent PCI
      devices.

    o OsReadPciConfiguration
      Please see pci_resource_{start/len} and friends.

    At this point, lnxosl.c will be removable and nobody will regret it. 

    --
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: YhLu: "RE: 256 apic id for amd64"

    Relevant Pages