Re: [patch 04/11] uml: refuse to run without skas if no tt mode in

From: Blaisorblade (blaisorblade_at_yahoo.it)
Date: 01/14/05

  • Next message: Dave Jiang: "[PATCH 2/5] resource: some driver updates for u64 resource" 
    To: Jeff Dike <jdike@addtoit.com>
Date:	Fri, 14 Jan 2005 21:08:25 +0100

    On Friday 14 January 2005 20:24, Jeff Dike wrote:
    > Is it my imagination, or did you put the definition of can_do_skas under
    > #ifdef UML_CONFIG_MODE_SKAS and failed to do the same for the call?

    Look at the end:

     #else
    +int can_do_skas(void)
    +{
            return(0);
    -#endif
     }
    +#endif

    This dummy call could be inlined / moved, anyway this is not performance
    critical - it's anyway nicer to have such null defines in headers. I'll clean
    it up.

    While checking your statement, I also discovered that here:

    int mode_tt = DEFAULT_TT;
    (where DEFAULT_TT is a macro depending on CONFIG options, which is always 0
    except if SKAS mode is disabled)

    is ignored, because of the subsequent:

            mode_tt = force_tt ? 1 : !can_do_skas();

    So we can probably get rid of DEFAULT_TT. I'll do this in the future. 

    -- 
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Dave Jiang: "[PATCH 2/5] resource: some driver updates for u64 resource"