Re: [Linux-ATM-General] Kernel 2.6.10 and 2.4.29 Oops fore200e (fwd)

From: Mike Westall (westall_at_cs.clemson.edu)
Date: 01/24/05

  • Next message: William Lee Irwin III: "Re: Query on remap_pfn_range compatibility" 
    Date:	Mon, 24 Jan 2005 17:27:23 -0500
To: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>

    You could also just revert to kernel 2.4.25 or
    earlier. Someone who was apparently oblivious
    to the fact that device driver send routines
    were "routinely" called in irq context and/or
    that it was a <very bad thing> to call schedule()
    under such circumstances slipped that one in
    sometime between 2.4.25 which is OK and 2.4.28
    where it is broken.

    In 2.4.25 and earlier it was a simple busy wait loop
    in which "goto retry_here;" immediately followed
    the "if" statement. This was safe, albeit MP unfriendly
    because of the spin_lock()/unlock() on each iteration.

    I'd say just delete the if and drop the damn
    packet.

    At any rate someone who has access to the golden code
    should fix this one way or another ASAP because its
    definitely seriously broken the way it is now.

    Mike

    chas williams - CONTRACTOR wrote:
    > In message <Pine.LNX.4.61L.0501210835270.6993@lt.wsisiz.edu.pl>,Lukasz Trabinsk
    > i writes:
    >
    >>Sorry, but I don;t understand, what line, i am not kernel guru. :/
    >
    >
    > look for the following code:
    >
    > /* retry once again? */
    > if(--retry > 0) {
    > schedule();
    > goto retry_here;
    > }
    >
    >
    > change schedule() to udelay(50) and see if things are 'better'.
    >
    >
    >>Is was happened on 2.4.29, too. It is a interrupt problem?
    >
    >
    > its calling a routine that might sleep while in the transmit routine.
    > this is not allow.
    >
    >
    > -------------------------------------------------------
    > This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
    > Tool for open source databases. Create drag-&-drop reports. Save time
    > by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
    > Download a FREE copy at http://www.intelliview.com/go/osdn_nl
    > _______________________________________________
    > Linux-atm-general mailing list
    > Linux-atm-general@lists.sourceforge.net
    > https://lists.sourceforge.net/lists/listinfo/linux-atm-general
    >
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: William Lee Irwin III: "Re: Query on remap_pfn_range compatibility"

    Relevant Pages

    • Re: [RFC 2.6.11-rc2-mm2 7/7] mm: manual page migration -- sys_page_migrate
      ... Are the usual kill-like permissions sufficient? ... In the following routine, tighten up some vertical spacing, ... migrated on success, not zero. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] 2.6 SGI Altix I/O code reorganization
      ... Doing it for the general sn_pci_init routine would let us ... get rid of the check for ia64_platform_isin one of the routines, ... It will be great to avoid spinning this big patch. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • vgone() calling VOP_CLOSE() -> blocked threads?
      ... In my current TTY design, I hold a count of the amount of ... threads that are sleeping in the line discipline. ... routine, expecting that the device is completely unused. ... The device driver should have a seperate routine to wake ...
      (freebsd-arch)
    • RE: [PATCH 22/82] remove linux/version.h from drivers/message/fus ion
      ... The routine scsi_device_online is a function, ... Anybody on the linux forums have any ideas? ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] arch/x86_64/kernel/ptrace.c linux-2.6.14.4
      ... After looking at the process.c and ldt.c source code, ... routine in process.c, and the read_ldtroutine below is based off of ... didn't do that in this version of the patch. ... To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ ...
      (Linux-Kernel)