Re: 2.6.11-rc2-mm1

From: Pavel Machek (pavel_at_ucw.cz)
Date: 01/25/05

  • Next message: Pierre Ossman: "Re: Page fault in umount" 
    Date:	Tue, 25 Jan 2005 20:35:40 +0100
To: Christoph Hellwig <hch@infradead.org>, Andrew Morton <akpm@osdl.org>, johnpol@2ka.mipt.ru, greg@kroah.com, linux-kernel@vger.kernel.org

    Hi!

    > Review of the superio subsystem sneaked in through bk-i2c.patch:
    >
    >
    > diff -Nru a/drivers/superio/Kconfig b/drivers/superio/Kconfig
    > --- /dev/null Wed Dec 31 16:00:00 196900
    > +++ b/drivers/superio/Kconfig 2005-01-23 22:34:15 -08:00
    > @@ -0,0 +1,56 @@
    > +menu "SuperIO subsystem support"
    > +
    > +config SC_SUPERIO
    > + tristate "SuperIO subsystem support"
    > + depends on CONNECTOR
    > + help
    > + SuperIO subsystem support.
    > +
    > + This support is also available as a module. If so, the module
    > + will be called superio.ko.
    >
    > This doesn't mention what "SuperIO" is at all. Also please skip the .ko
    > postfix for the module name as the intree Kconfigs do. The boilerplate has
    > changed to:
    >
    > To compile this driver as a module, choose M here: the
    > module will be called <foo>.

    Could we kill this boilerplate? Just explain modules in CONFIG_MODULE
    or something like that. Or making module name mandatory parameter for
    tristates, or something like that...

                                                                    Pavel 

    -- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Pierre Ossman: "Re: Page fault in umount"

    Relevant Pages

    • 2.4.28-pre3: broken ips update
      ... of the driver. ... do even the simplest compile testing when blindly submitting the latest ... There had been need of rain for many days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • 2.6.0-test5 build problems
      ... the problems are during the install] ... Adaptec AIC7xxx Fast ->U160 support (New Driver) ... Compile in Debugging ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: mm kernel oops with r8169 & named, PREEMPT
      ... I wasn't able to get the kernel to compile with just the reiser4 ... patches from the broken-out dir on the ftp. ... However I was able to verify it's not a problem with the r8169 driver. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Via Velocity Concerns
      ... before and kernel paniced. ... the driver also didn't compile cleanly. ... I had to add a member to a struct to get it to compile correctly. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [git tree] drm dumb maintainer forgot which tree he pushed..
      ... There was a patch to the i915 driver to make it compile which I put in ... David Airlie, Software Engineer ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    Loading