Re: [PATCH 1/1] pci: Block config access during BIST (resend)
From: Benjamin Herrenschmidt (benh_at_kernel.crashing.org)
Date: 01/26/05
- Previous message: Emmanuel Fleury: "[2.6.10] PCMCIA/CardBus Wifi Card Problem"
- In reply to: Brian King: "Re: [PATCH 1/1] pci: Block config access during BIST (resend)"
- Next in thread: Alan Cox: "Re: [PATCH 1/1] pci: Block config access during BIST (resend)"
- Reply: Alan Cox: "Re: [PATCH 1/1] pci: Block config access during BIST (resend)"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
To: brking@us.ibm.com Date: Thu, 27 Jan 2005 09:10:05 +1100
On Wed, 2005-01-26 at 10:34 -0600, Brian King wrote:
> Here is the last one. I've looked at making userspace sleep until BIST
> is finished. The downside I see to this is that is complicates the patch
> due to the following reasons:
>
> 1. In order to also make this work for Ben's PPC power management usage
> would require an additional flag and additional APIs to set and clear
> the flag.
> 2. Since BIST can be run at interrupt context, the interfaces to block
> and unblock userspace accesses across BIST must be callable from
> interrupt context. This prevents the usage of semaphores or simple
> wait_event macros and requires new macros that carefully check the new
> pci device flag and manage the spinlock.
>
Well, I honestly think that this is unnecessary burden. I think that
just dropping writes & returning data from the cache on reads is enough,
blocking userspace isn't necessary, but then, I may be wrong ;)
Ben.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Emmanuel Fleury: "[2.6.10] PCMCIA/CardBus Wifi Card Problem"
- In reply to: Brian King: "Re: [PATCH 1/1] pci: Block config access during BIST (resend)"
- Next in thread: Alan Cox: "Re: [PATCH 1/1] pci: Block config access during BIST (resend)"
- Reply: Alan Cox: "Re: [PATCH 1/1] pci: Block config access during BIST (resend)"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
