Re: multiple neighbour cache tables for AF_INET

From: Herbert Xu (herbert_at_gondor.apana.org.au)
Date: 01/28/05

  • Next message: Andrew Morton: "Re: [PATCH] relayfs redux, part 2" 
    To: wweissmann@gmx.at (Wilfried Weissmann)
Date:	Sat, 29 Jan 2005 09:19:49 +1100

    Wilfried Weissmann <wweissmann@gmx.at> wrote:
    >
    > The kernels 2.4.28+ and 2.6.9+ with IPv4 and ATM-CLIP enabled have bugs in
    > the neighbour cache code. neigh_delete() and neigh_add() only work properly
    > if one cache table per address family exist. After ATM-CLIP installed a
    > second cache table for AF_INET, neigh_delete() and neigh_add() only examine
    > the first table (the ATM-CLIP table if IPv4 and ATM-CLIP are compiled into
    > the kernel). neigh_dump_info() is also affected if the neigh_dump_table()
    > call fails.

    Indeed, this has been the case for a very long time.

    IMHO you need to give the user a way to specify which table they want
    to operate on. If they don't specify one, then the current behaviour
    of choosing the first table found is reasonble.

    Cheers, 

    -- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Andrew Morton: "Re: [PATCH] relayfs redux, part 2"

    Relevant Pages

    • Re: Problems with kernel mmap (failing tst-mmap-eofsync in glibc on parisc)
      ... > This last read fails to get the data on parisc. ... > CPU cache is virtually indexed, and the page the write is storing the ... flush_dcache_pagechecks both the shared and non-shared mmap lists, ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: why swap at all?
      ... But this doesn't help in this case as the image-file is up to 4,4GB in ... whole which means that it ALONE can fill up the whole cache. ... Real Programmers consider "what you see is what you get" to be just as ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: statfs() / statvfs() syscall ballsup...
      ... regular writes and read stuff off the disk that was a potential security ... So right now we have extra code and extra complexity (which implies not ... through the page cache to make sure that it's safe. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: A problem about DIRECT IO on ext3
      ... fails if the offset or buffer is NOT filesystem blocksize ... So, its possible that your buffer is atleast 512byte aligned, ... > soft/hard sector sizes. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • fastboot, diskstat
      ... that the total time for prefetching + actual boot was only 10% shorter, ... actually cache the pages I touched, ... Also, regarding the directory entries, are they accessed via the buffer ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)