Re: [RFC][PATCH] add driver matching priorities

From: Adam Belay (abelay_at_novell.com)
Date: 01/29/05

  • Next message: Dmitry Torokhov: "Re: [RFC][PATCH] add driver matching priorities"
    To: Dmitry Torokhov <dtor_core@ameritech.net>
    Date:	Fri, 28 Jan 2005 18:33:06 -0500
    
    

    On Fri, 2005-01-28 at 18:23 -0500, Dmitry Torokhov wrote:
    > On Friday 28 January 2005 17:30, Adam Belay wrote:
    > > Of course this patch is not going to be effective alone. We also need
    > > to change the init order. If a driver is registered early but isn't the
    > > best available, it will be bound to the device prematurely. This would
    > > be a problem for carbus (yenta) bridges.
    > >
    > > I think we may have to load all in kernel drivers first, and then begin
    > > matching them to hardware. Do you agree? If so, I'd be happy to make a
    > > patch for that too.
    > >
    >
    > I disagree. The driver core should automatically unbind generic driver
    > from a device when native driver gets loaded. I think the only change is
    > that we can no longer skip devices that are bound to a driver and match
    > them all over again when a new driver is loaded.
    >

    That's another option. My concern is that if a generic driver pokes
    around with hardware, it may fail to initialize properly when the actual
    driver is loaded. There are other problems too. If the system were to
    be suspended while the generic driver was loaded, the restore_state code
    may be incorrect, also rendering the device unusable.

    I'd like to leave the option of unloading generic driver open. I just
    think we need to be aware of potential problems it might cause, before
    deciding to go that direction.

    Thanks,
    Adam

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Dmitry Torokhov: "Re: [RFC][PATCH] add driver matching priorities"

    Relevant Pages

    • Re: r8169.c
      ... > who tries to work with the 8169 driver on the long run). ... > Btw merging a 20 megaton patch is not the way network drivers changes ... > the suggested format). ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: ksoftirqd uses 99% CPU triggered by network traffic (maybe RLT-8139 related)
      ... Patch r8139-20.patch didn't help. ... crash but without DEBUG it did crash. ... Here is a snapshot from the log file when driver is crashing: ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] iSeries virtual disk
      ... > patch for a new driver. ... Can you split them out into a separate patch? ... > better merging it into it's only caller. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: radeonfb: cannot map FB
      ... I see a big DRM merge in .23 but it's unrelated to the fb driver. ... will be happy to get your patch. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • RE: 2.6.7-rc3-mm2
      ... The 3w-xxxx.c patch is definately bogus. ... It would have applied against the driver ... > Sony Clie USB driver fix ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)