Re: [PATCH 1/2] pci: Arch hook to determine config space size
From: Greg KH (greg_at_kroah.com)
Date: 01/29/05
- Previous message: Gianni Tedesco: "Re: compat ioctl for submiting URB"
- In reply to: Christoph Hellwig: "Re: [PATCH 1/2] pci: Arch hook to determine config space size"
- Next in thread: Brian King: "Re: pci: Arch hook to determine config space size"
- Reply: Brian King: "Re: pci: Arch hook to determine config space size"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Fri, 28 Jan 2005 20:06:47 -0800 To: Christoph Hellwig <hch@infradead.org>, brking@us.ibm.com, linux-kernel@vger.kernel.org, linuxppc64-dev@ozlabs.org
On Fri, Jan 28, 2005 at 06:52:34PM +0000, Christoph Hellwig wrote:
> > +int __attribute__ ((weak)) pcibios_exp_cfg_space(struct pci_dev *dev) { return 1; }
>
> - prototypes belong to headers
> - weak linkage is the perfect way for total obsfucation
>
> please make this a regular arch hook
I agree. Also, when sending PCI related patches, please cc the
linux-pci mailing list.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Gianni Tedesco: "Re: compat ioctl for submiting URB"
- In reply to: Christoph Hellwig: "Re: [PATCH 1/2] pci: Arch hook to determine config space size"
- Next in thread: Brian King: "Re: pci: Arch hook to determine config space size"
- Reply: Brian King: "Re: pci: Arch hook to determine config space size"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]