Re: 2.6.11-rc2-mm2

From: Brice Goglin (Brice.Goglin_at_ens-lyon.fr)
Date: 01/29/05

  • Next message: Sean Neakums: "Re: 2.6.11-rc2-mm2"
    Date:	Sat, 29 Jan 2005 23:52:19 +0100
    To: Andrew Morton <akpm@osdl.org>
    
    

    Andrew Morton a écrit :
    >
    > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc2/2.6.11-rc2-mm2/
    >
    > Changes since 2.6.11-rc2-mm1:
    > +fix-kallsyms-insmod-rmmod-race.patch
    > +fix-kallsyms-insmod-rmmod-race-fix.patch
    > +fix-kallsyms-insmod-rmmod-race-fix-fix.patch
    >
    > fix a modules race

    Hi Andrew,

    CONFIG_STOP_MACHINE is not defined on my laptop. This breaks module loading.
    The reason is that stop_machine_run does nothing, especially
    it does not call the function that is passed as a parameter.

    Looks like -fix needs another fix :)

    What about a patch like this one ?

    Regards,
    Brice

    Signed-off-by: Brice Goglin <Brice.Goglin@ens-lyon.org>

    --- linux-mm/include/linux/stop_machine.h.orig 2005-01-29 23:37:11.000000000 +0100
    +++ linux-mm/include/linux/stop_machine.h 2005-01-29 23:37:31.000000000 +0100
    @@ -57,7 +57,7 @@
      static inline int stop_machine_run(int (*fn)(void *), void *data,
                                         unsigned int cpu)
      {
    - return 0;
    + return fn(data);
      }

      #endif /* CONFIG_STOP_MACHINE */
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Sean Neakums: "Re: 2.6.11-rc2-mm2"

    Relevant Pages

    • Re: 2.6.13-rc3-mm3
      ... On Thu, 28 Jul 2005, Andrew Morton wrote: ... becoming a common case for multi-core applications. ... I have just sent a fix to you this morning when I got your messages. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: ppc64 build broke between 2.6.11-bk6 and 2.6.11-bk7
      ... > Andrew Morton writes: ... > The patch Andrew mentions above converts the Kconfig entry for FB_MATROX to do a ... matroxfb-compile-error.patch was a valid fix for a compile problem. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.9-rc2-mm2
      ... On Wed, 22 Sep 2004, Andrew Morton wrote: ... but which exact patch of those listed does fix this problem? ... Or is the fix ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: 2.6.10-rc1-mm5 [u]
      ... On Sat, 2004-11-13 at 13:22 -0800, Andrew Morton wrote: ... > the retest? ... this seems to fix it (usually one thread at least have already hung ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Soft lockup with -mm
      ... Brice Goglin a écrit: ... > Andrew Morton a écrit: ... This box is running 2.6.12-rc3-mm2 with Oleg's fix for 12 days. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)