Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups
From: Adrian Bunk (bunk_at_stusta.de)
Date: 01/30/05
- Previous message: Jesper Juhl: "[PATCH] micro optimization in kernel/params.c; don't call to_module_kobject before we really have to."
- In reply to: Bartlomiej Zolnierkiewicz: "Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups"
- Next in thread: Bartlomiej Zolnierkiewicz: "Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups"
- Reply: Bartlomiej Zolnierkiewicz: "Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Sun, 30 Jan 2005 00:46:24 +0100 To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
On Sat, Jan 29, 2005 at 06:51:25PM +0100, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> On Sat, 29 Jan 2005 18:11:08 +0100, Adrian Bunk <bunk@stusta.de> wrote:
> > This patch makes the needlessly global function isp16_init static.
> >
> > As a result, it turned out that both this function and some other code
> > are only required #ifdef MODULE.
>
> Your patch is correct but it is wrong. ;)
>
> #ifdefs around isp16_init() need to be removed as
> otherwise this driver is not initialized in built-in case.
It's somehow initialized via isp16_setup.
> Bartlomiej
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Jesper Juhl: "[PATCH] micro optimization in kernel/params.c; don't call to_module_kobject before we really have to."
- In reply to: Bartlomiej Zolnierkiewicz: "Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups"
- Next in thread: Bartlomiej Zolnierkiewicz: "Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups"
- Reply: Bartlomiej Zolnierkiewicz: "Re: [2.6 patch] drivers/cdrom/isp16.c: small cleanups"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
