Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static
From: Adrian Bunk (bunk_at_stusta.de)
Date: 01/31/05
- Previous message: Stelian Pop: "Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static"
- In reply to: Stelian Pop: "Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static"
- Next in thread: Dmitry Torokhov: "Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 31 Jan 2005 22:53:12 +0100 To: Stelian Pop <stelian@popies.net>, linux-kernel@vger.kernel.org
On Mon, Jan 31, 2005 at 10:49:05PM +0100, Stelian Pop wrote:
> On Mon, Jan 31, 2005 at 06:35:08PM +0100, Adrian Bunk wrote:
>
> > This patch makes three needlessly global structs static.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > ---
> >
> > drivers/char/sonypi.c | 76 +++++++++++++++++++++++++++++++++++++++++-
> > drivers/char/sonypi.h | 74 ----------------------------------------
> > 2 files changed, 75 insertions(+), 75 deletions(-)
>
> sonypi.h is a "local" header file used only by sonypi.c.
>
> I would like to keep those tables in sonypi.h rather than putting
> all into sonypi.c (or we could as well remove sonypi.h and put all the
> contents into the .c).
>
> What about:
>...
That's also OK with me.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Stelian Pop: "Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static"
- In reply to: Stelian Pop: "Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static"
- Next in thread: Dmitry Torokhov: "Re: [2.6 patch] drivers/char/sonypi.c: make 3 structs static"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
