Re: Radeon FB troubles with recent kernels

From: Antonino A. Daplas (adaplas_at_hotpop.com)
Date: 02/15/05

  • Next message: Larry McVoy: "Re: [BK] upgrade will be needed" 
    To: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Matt Mackall <mpm@selenic.com>
Date:	Tue, 15 Feb 2005 08:02:46 +0800

    On Tuesday 15 February 2005 07:08, Benjamin Herrenschmidt wrote:
    > > Appeared ? hah... that's strange. X is known to *** up the chip when
    > > quit, but I wouldn't have expected any change due to the new version of
    > > radeonfb. From what you describe, it looks like an offset register is
    > > changed by X, or the surface control.
    > >
    > > My patch did not change any of radeonfb accel code though...
    > >
    > > I'll catch up with you on IRC ...
    >
    > Ok, from our discussions, it's not related to the power management code,
    > and an engine reset triggered by fbset fixes it. So at this point, I can
    > see no change in the driver explaining it...
    >
    > We did some changes to the VT layer to force a mode setting (and thus an
    > engine reset) when going away from X, so I can't see why that wouldn't
    > work, while using fbset later on works ... this goes through the same
    > code path in the driver... unless we are facing a timing issue...

    You can also try inserting something like this before register_framebuffer()

    info->flags |= FBINFO_MISC_MODESWITCHLATE;

    to delay the call to set_par as late as possible. It's the same hack used
    in rivafb, but there were reports before that it does not work with a few
    radeon setups.

    Tony

    >
    > X is known to play funny tricks, like touching the engine when it's in
    > the background (not frontmost VT) and quit, or possibly other bad things
    > on console switch. Maybe I changed enough delays (speeded up) the mode
    > switch so that we fall into a case where X has not finished mucking up
    > with us...
    >
    > Can you try adding some msleep(200) or so at the beginning at
    > radeonfb_set_par() or radeon_write_mode() to see if that makes any
    > difference ?
    >
    > Some printk's in there would help to... I expect calls to
    > radeon_engine_init() to fix it and such a call is present in the mode
    > restore unless accel is disabled...
    >
    > Can you check what's happening ?
    >
    > Ben.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

  • Next message: Larry McVoy: "Re: [BK] upgrade will be needed"