Re: PATCH 2.6.11-rc4]: IBM TrackPoint configuration support

From: Vojtech Pavlik (vojtech_at_suse.cz)
Date: 02/15/05

  • Next message: krishna: "Re: What is the Purpose of GPIO Controller." 
    Date:	Tue, 15 Feb 2005 15:16:18 +0100
To: Dmitry Torokhov <dtor_core@ameritech.net>

    On Sun, Feb 13, 2005 at 08:31:01PM -0500, Dmitry Torokhov wrote:
    > On Sunday 13 February 2005 19:32, Stephen Evanchik wrote:
    > > Here is the latest IBM TrackPoint patch. I believe I made all of the
    > > necessary changes in this release including the removal of the
    > > middle-to-scroll functionality. One item I didn't address was a
    > > comment about checking the return code of ps2_command ..
    > >
    > > I looked at other usages and it wasn't clear to me how to actually
    > > implement something that is sane. In some places an error causes a
    > > return out of the function and in others the return value is ignored.
    > > Should I check each return value or the first ?
    >
    > I would check all 3 ps2_command calls in trackpoint_init and leave
    > the rest as is.
    >
    > One more thing - I'd like to see more descriptive names of sysfs
    > attributes, for example I'd change "ptson" to "press_to_select",
    > "mb" to "middle_btn", etc.
     
    Stephen, if you fix the above, and send me the patch, I'll merge it,
    there isn't any other problem with it. 

    -- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: krishna: "Re: What is the Purpose of GPIO Controller."