2.4 compile errors in 32-bit sys_revcmsg fixes

From: Meelis Roos (mroos_at_linux.ee)
Date: 02/22/05

  • Next message: Jes Sorensen: "[patch -mm series] ia64 specific /dev/mem handlers"
    Date:	Tue, 22 Feb 2005 11:48:31 +0200 (EET)
    To: Linux Kernel list <linux-kernel@vger.kernel.org>, sfr@canb.auug.org.au
    
    

    This is todays 2.4.30-pre1+BK snapshot on a sparc64:

    gcc -D__ASSEMBLY__ -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -m64 -mcpu=ultrasparc -Wa,--undeclared-regs -ansi -c -o sys32.o sys32.S
    gcc -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -m64 -pipe -mno-fpu -mcpu=ultrasparc -mcmodel=medlow -ffixed-g4 -fcall-used-g5 -fcall-used-g7 -Wno-sign-compare -Wa,--undeclared-regs -finline-limit=100000 -nostdinc -iwithprefix include -DKBUILD_BASENAME=sys_sparc32 -c -o
    sys_sparc32.o sys_sparc32.c
    sys_sparc32.c: In function `cmsg32_recvmsg_fixup':
    sys_sparc32.c:2683: error: called object is not a function
    make[1]: *** [sys_sparc32.o] Error 1

    The lines in question are
    if ((clen64 < CMSG_ALIGN(sizeof(*ucmsg)))
                      (clen64 > (orig_cmsg_len + wp - workbuf))) {

    Is a "||" missing, or something else?

    It appears the same lines are in most fixed architectures so probably
    more architectures don't compile.

    -- 
    Meelis Roos (mroos@linux.ee)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    

  • Next message: Jes Sorensen: "[patch -mm series] ia64 specific /dev/mem handlers"

    Relevant Pages

    • Re: [PATCH] Kprobes: wrapper to define jprobe.entry
      ... Andrew Morton wrote: ... > part has been tested and Dave has had a go at the sparc64 version. ... I think the person changing the data type should be the one fixing ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] cpumask 5/10 rewrite cpumask.h - single bitmap based implementation
      ... > We avoided doing this because in some situations the compiler will not pass ... > such a cpumask_t in a register, ... Although for some reason your patches shrink my sparc64 build from ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [2.6] busybox EFAULT on sparc64
      ... give the attached patch a try. ... I've been meaning to make these improvements for a long time ... on sparc64 and this bug gave me a good reason to just do it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: Page fault scalability patch V18: Drop first acquisition of ptl
      ... On Wed, 2 Mar 2005, David S. Miller wrote: ... > However, if this pte_cmpxchgthing is used for removing access, then ... > sparc64 can't use it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH 2/2] page table iterators
      ... > or making drastric changes in same. ... But on sparc64 I've set ... handler when it encounters a corrupted page table. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)