Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code

From: Martin Mares (mj_at_ucw.cz)
Date: 02/28/05

  • Next message: martin f krafft: "Re: swsusp logic error?" 
    Date:	Mon, 28 Feb 2005 15:43:06 +0100
To: colbuse@ensisun.imag.fr

    Hello!

    > I agree :) . But, if we look to the code, we can notice that there is actually
    > no reason for npar to be unsigned. What do you think of this version?

    What does it try to solve? Your version is in no way better than the previous one.
    The previous one was more readable and it's quite possible that both
    will be compiled to the same sequence of instructions.

    Also, as Arjan noted, if you want to improve the code, use memset.

                                    Have a nice fortnight 

    -- 
Martin `MJ' Mares   <mj@ucw.cz>   http://atrey.karlin.mff.cuni.cz/~mj/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
American patent law: two monkeys, fourteen days.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: martin f krafft: "Re: swsusp logic error?"

    Relevant Pages