Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code
emmanuel.colbus_at_ensimag.imag.fr
Date: 02/28/05
- Previous message: Nickolay: "oops after 2-3 days working..."
- In reply to: Stelian Pop: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Next in thread: Stelian Pop: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Reply: Stelian Pop: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Reply: Adrian Bunk: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Date: Mon, 28 Feb 2005 18:29:39 +0100 (MET) To: Stelian Pop <stelian@popies.net>
On Mon, 28 Feb 2005, Stelian Pop wrote:
> On Mon, Feb 28, 2005 at 04:06:14PM +0100, colbuse@ensisun.imag.fr wrote:
>
> > + /* Setting par[]'s elems at 0. */
> > + memset(par, 0, NPAR*sizeof(unsigned int));
>
> No need for the comment here, everybody understands C.
I knew this code would be understood, but I like comments :-) .
Well, without it, it gives :
--- old/drivers/char/vt.c 2004-12-24 22:35:25.000000000 +0100
+++ new/drivers/char/vt.c 2005-02-28 18:19:11.782717810 +0100
@@ -1655,8 +1655,8 @@
vc_state = ESnormal;
return;
case ESsquare:
- for(npar = 0 ; npar < NPAR ; npar++)
- par[npar] = 0;
+ memset(par, 0, NPAR*sizeof(unsigned int));
npar = 0;
vc_state = ESgetpars;
if (c == '[') { /* Function key */
Any other comments/remarks, or is _this_ patch version acceptable?
-- Emmanuel Colbus Club GNU/Linux ENSIMAG - Departement telecoms - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Previous message: Nickolay: "oops after 2-3 days working..."
- In reply to: Stelian Pop: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Next in thread: Stelian Pop: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Reply: Stelian Pop: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Reply: Adrian Bunk: "Re: [patch 3/2] drivers/char/vt.c: remove unnecessary code"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Relevant Pages
|
|
