Re: [2.6 patch] SCSI: possible cleanups

From: Christoph Hellwig (hch_at_infradead.org)
Date: 02/28/05

  • Next message: Bill Davidsen: "Re: [PATCH 2.6.11-rc4] oom_kill.c: Kill obvious processes first"
    Date:	Mon, 28 Feb 2005 22:25:09 +0000
    To: Adrian Bunk <bunk@stusta.de>
    
    

    On Mon, Feb 28, 2005 at 10:31:59PM +0100, Adrian Bunk wrote:
    > Before I'm getting flamed to death:
    > This patch contains possible cleanups. If parts of this patch conflict
    > with pending changes these parts of my patch have to be dropped.
    >
    > This patch contains the following possible cleanups:
    > - make needlessly global code static
    > - remove or #if 0 the following unused functions:
    > - scsi.h: print_driverbyte
    > - scsi.h: print_hostbyte

    these two please kill.

    > - constants.c: scsi_print_hostbyte
    > - constants.c: scsi_print_driverbyte

    these we'll probably keep for now.

    > - scsi_scan.c: scsi_scan_single_target

    this one will grow a user soon, but maybe it'll be completely
    rewritten before.

    > - remove the following unneeded EXPORT_SYMBOL's:
    > - constants.c: __scsi_print_sense

    this was put in for a drivea and makes sense as API.

    > - hosts.c: scsi_host_lookup

    we should probably kill this export.

    > - scsi.c: scsi_device_cancel
    > - scsi_lib.c: scsi_device_resume

    dito.

    > - scsi_error.c: scsi_normalize_sense
    > - scsi_error.c: scsi_sense_desc_find

    st is expected to use these soon.

    > - scsi_scan.c: scsi_rescan_device

    aacraid was going to use that one, Mark, any chance to get a patch
    anytime soon?

    > - scsi_scan.c: scsi_scan_single_target

    as mentioned above we'll need this one soon.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/


  • Next message: Bill Davidsen: "Re: [PATCH 2.6.11-rc4] oom_kill.c: Kill obvious processes first"

    Relevant Pages

    • Re: sis190
      ... Francois Romieu wrote: ... > Patch of the day: ... kill, I'll build that today and try and kill it. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [TRIVIAL] sanitize power management config menus
      ... I had similar patch in queue somewhere. ... Swap partitions work. ... Kill the note about SCSI. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [2.6 patch] SCSI NCR53C9x.c: some cleanups (fwd)
      ... The patch forwarded below still applies and compiles against ... The patch below contains some cleanups. ... extern int esp_abort; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [patch *] remove 450 unnecessary #includes of sched.h
      ... On Wed, 25 Aug 2004, William Lee Irwin III wrote: ... Let's see how often we can kill it's include lines. ... No patch either, since I just realized it's over 200k in size. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • [PATCH] Lets kill verify_area() and try not to kill Andrew
      ... This is the start of "kill verify_areaand try not to kill Andrew in the ... In the previous "kill verify_area" thread you mentioned that converting ... This is that first ~10% patch. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)