Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

From: Pavel Machek (pavel_at_suse.cz)
Date: 03/01/05

  • Next message: Horst von Brand: "Re: SPARC64: Modular floppy?" 
    Date:	Tue, 1 Mar 2005 13:08:43 +0100
To: "Eric W. Biederman" <ebiederm@xmission.com>

    Hi!

    > > > In `subj` kernel, machine no longer powers down at the end of
    > > > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk.
    > >
    > > Binary searching indicates that this is due to
    > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc5/2.6.11-rc5-mm1/broken-out/acpi_power_off-bug-fix.patch.
    > >
    > >
    > > I'll drop it. That patch is pretty ugly-looking anyway (ACPI code in
    > > drivers/base/power/?).
    > >
    > > Perhaps someone who is hitting the problem which that patch addresses could
    > > raise a bugzilla entry.
    > >
    > > Oh. It has one. http://bugme.osdl.org/show_bug.cgi?id=4041
    > >
    > > Anyway. It needs more work.
    >
    > Agreed.
    >
    > I threw it together to test a specific code path, and the fact it
    > fails in software suspend is actually almost confirmation that I am on
    > the right track. This actually fixed the case I was testing.
    >
    > In this case the failure is simply because system_state is
    > not set to SYSTEM_POWER_OFF before
    > kernel/power/disk.c:power_down() calls device_shutdown().
    > The appropriate reboot notifier is also not called..

    Can you suggest patch to do it right? Or perhaps there should be
    just_plain_power_machine_down() that does all neccessary
    trickery?
                                                            Pavel 

    -- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
  • Next message: Horst von Brand: "Re: SPARC64: Modular floppy?"

    Relevant Pages

    • Re: Linux 2.6.9-ac5 - more stupid FAT filesystems
      ... >> unless they are hitting one of the bugs described or need the new ... the patch from me is completely bogus. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [parisc-linux] Re: [PATCH 3/9] mm: parisc pte atomicity
      ... using your own tmpalias area sounds much better than getting ... I've simply not wrapped my head around the races, ... it looks like we agree that my patch is necessary and valid as is; ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: keyboard - was: Re: Linux 2.6.0-test4
      ... >> I was able to get the key unstuck by switching back and forth between ... I rebuild my kernel including your patch; ... I'll get back to you once I verify that the problem doesn't occur ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [CFT][PATCH] 2.6.4-rc1 remove x86 boot page tables
      ... > For VISWS I think you actually need to turn paging off explicitly. ... The patch will need a few tweaks but it should be fairly straight forward. ... send the line "unsubscribe linux-kernel" in ...
      (Linux-Kernel)
    • Re: [PATCH] clarify message and give support contact for non-GPL modules
      ... The author of the second module ... So here is another attempt at the patch. ... send the line "unsubscribe linux-kernel" in ... More majordomo info at http://vger.kernel.org/majordomo-info.html ...
      (Linux-Kernel)